Skip to content

NXP backend: Fix unittest-nxp-neutron introduced in 0012ffaf9 #12584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

NXP backend: Fix unittest-nxp-neutron introduced in 0012ffaf9 #12584

merged 1 commit into from
Jul 17, 2025

Conversation

@robert-kalmar
Copy link
Collaborator

@robert-kalmar robert-kalmar commented Jul 17, 2025 •
edited by pytorch-bot bot
Loading

Summary

Test plan

pytest -c /dev/null backends/nxp/tests/

cc @digantdesai @JakeStevens

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12584

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 744631a with merge base 373be8c (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2025
@robert-kalmar robert-kalmar added the module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ label Jul 17, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JakeStevens
JakeStevens approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@JakeStevens JakeStevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how this file was missed, should be better going forward with moving the nxp tests

@JakeStevens JakeStevens merged commit 012c62d into pytorch:main Jul 17, 2025
99 of 103 checks passed
lucylq pushed a commit that referenced this pull request Jul 17, 2025
@robert-kalmar @lucylq
NXP backend: Fix unittest-nxp-neutron introduced in 0012ffa (#12584)
199870d 
### Summary

### Test plan
```
pytest -c /dev/null backends/nxp/tests/
```

cc @digantdesai @JakeStevens
@robert-kalmar
Copy link
Collaborator Author

not sure how this file was missed, should be better going forward with moving the nxp tests

You mean moving from trunk to pull? That is already in place, and the error get triggered on the respective PR #12546. But merged despite that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeStevens JakeStevens JakeStevens approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert-kalmar @JakeStevens