Rename docker image to use ci-image:name syntax #12599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the docker image names from
executorch/name:commitsha
toexecutorch/ci-image:name-commitsha
I changed the docker image calculation step at some point to allow tags have names and still have the .ci/docker hash. By changing the names from
name:commitsha
toci-image:name-commitsha
, it is no longer necessary to create new ecr repos on AWS whenever a newname
is added, which only a few people can do. Instead, everything will go underci-image
with tagsTesting: Run CI, if any job pull the old image, its bad. Not sure how to check tho
Pros:
Cons: