Skip to content

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jul 17, 2025

This changes the docker image names from executorch/name:commitsha to executorch/ci-image:name-commitsha

I changed the docker image calculation step at some point to allow tags have names and still have the .ci/docker hash. By changing the names from name:commitsha to ci-image:name-commitsha, it is no longer necessary to create new ecr repos on AWS whenever a new name is added, which only a few people can do. Instead, everything will go under ci-image with tags

Testing: Run CI, if any job pull the old image, its bad. Not sure how to check tho

Pros:

  • no longer need to wait for one of the people with permissions to create new ecr repo

Cons:

  • xkcd about standards
  • not sure how often new image names need to be created (probably not often at this point)
  • dont fix what isnt broken
  • testing this change is probably not super thorough

Copy link

pytorch-bot bot commented Jul 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12599

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ec32e93 with merge base 4456407 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@clee2000 clee2000 temporarily deployed to upload-benchmark-results July 17, 2025 20:41 — with GitHub Actions Inactive
@clee2000 clee2000 temporarily deployed to upload-benchmark-results July 17, 2025 21:45 — with GitHub Actions Inactive
@clee2000 clee2000 temporarily deployed to upload-benchmark-results July 17, 2025 23:19 — with GitHub Actions Inactive
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix, now we don't to manually create new entries for ExecuTorch anymore

@clee2000 clee2000 merged commit c9df2aa into main Jul 18, 2025
119 checks passed
@clee2000 clee2000 deleted the csl/docker_image_rename branch July 18, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants