Add target for no exceptions #12603
Merged
Add target for no exceptions #12603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12603
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit a9c8014 with merge base b793d45 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78501952 |
JakeStevens
added
the
release notes: none
limintang
approved these changes
Jul 17, 2025
JakeStevens
force-pushed
the
export-D78501952
branch
from
2884c80 to
f493b6a
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Jul 18, 2025
Summary: Current library only supports exceptions Add another target that does not support exceptions for certain embedded applications Reviewed By: limintang Differential Revision: D78501952
Summary: Pull Request resolved: pytorch#12603 Current library only supports exceptions Add another target that does not support exceptions for certain embedded applications Reviewed By: limintang Differential Revision: D78501952
JakeStevens
force-pushed
the
export-D78501952
branch
from
f493b6a to
a9c8014
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D78501952 |
Contributor
Author
|
@psiddh look okay to you? |
digantdesai
reviewed
Jul 21, 2025
| define_static_targets = True, | ||
| ) | ||
|
|
||
| executorch_generated_lib( |
Contributor
There was a problem hiding this comment.
Is there a better way to do it through modes?
digantdesai
approved these changes
Jul 21, 2025
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
Stamping to unblock.
Contributor
|
Ah shoot, sorry, I accidentally merged this PR into main... @JakeStevens @digantdesai I was trying to merge a different PR. |
Conarnar
pushed a commit
to Conarnar/executorch
that referenced
this pull request
Jul 25, 2025
Summary: Current library only supports exceptions Add another target that does not support exceptions for certain embedded applications Differential Revision: D78501952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Current library only supports exceptions
Add another target that does not support exceptions for certain embedded applications
Differential Revision: D78501952