Skip to content

[Backend Tester] Add backend filtering, improved test discovery #12624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2025

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jul 18, 2025

Iteratively update the backend test suite to support cleaner test flow registration, backend filtering, and a bit of misc incremental cleanup.

The test suite can now be invoked with python -m executorch.backends.test.suite.runner operators --backend xnnpack, for example.

[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Jul 18, 2025

@GregoryComer GregoryComer requested a review from cccclai as a code owner July 18, 2025 00:27
Copy link

pytorch-bot bot commented Jul 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12624

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit d21492b with merge base a27dd42 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Jul 18, 2025
ghstack-source-id: 31f569a
ghstack-comment-id: 3086061292
Pull-Request: #12624
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2025
@GregoryComer GregoryComer requested a review from digantdesai July 18, 2025 00:28
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jul 18, 2025
""" A factory function that returns a Tester instance for this lowering flow. """


def create_xnnpack_flow() -> TestFlow | None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def create_xnnpack_flow() -> TestFlow | None:
@classmethod
def from_name(name: str) -> TestFlow | None:
...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly prefer the approach of having individual methods that can be explicitly called per flow, but I'll defer to your judgement if you feel strongly about it.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D78708407.

[ghstack-poisoned]
[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D78708407.

@GregoryComer GregoryComer merged commit 76b08f3 into main Jul 22, 2025
171 of 176 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/77/head branch July 22, 2025 21:52
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
…rch#12624)

Iteratively update the backend test suite to support cleaner test flow
registration, backend filtering, and a bit of misc incremental cleanup.

The test suite can now be invoked with `python -m
executorch.backends.test.suite.runner operators --backend xnnpack`, for
example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants