-
Notifications
You must be signed in to change notification settings - Fork 646
[Backend Tester] Add backend filtering, improved test discovery #12624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12624
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit d21492b with merge base a27dd42 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
""" A factory function that returns a Tester instance for this lowering flow. """ | ||
|
||
|
||
def create_xnnpack_flow() -> TestFlow | None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def create_xnnpack_flow() -> TestFlow | None: | |
@classmethod | |
def from_name(name: str) -> TestFlow | None: | |
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I slightly prefer the approach of having individual methods that can be explicitly called per flow, but I'll defer to your judgement if you feel strongly about it.
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D78708407. |
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D78708407. |
…rch#12624) Iteratively update the backend test suite to support cleaner test flow registration, backend filtering, and a bit of misc incremental cleanup. The test suite can now be invoked with `python -m executorch.backends.test.suite.runner operators --backend xnnpack`, for example.
Iteratively update the backend test suite to support cleaner test flow registration, backend filtering, and a bit of misc incremental cleanup.
The test suite can now be invoked with
python -m executorch.backends.test.suite.runner operators --backend xnnpack
, for example.