Skip to content

Validate kTensorDimensionLimit #12684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Jul 22, 2025
Merged

Validate kTensorDimensionLimit #12684

facebook-github-bot merged 1 commit into from
Jul 22, 2025

Conversation

@JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Jul 21, 2025

Summary: Need to check this limit at deserialization since the ops rely on it

Differential Revision: D78675986

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12684

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit f4872e6 with merge base 0e5e342 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2025

This pull request was exported from Phabricator. Differential Revision: D78675986

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2025

This pull request was exported from Phabricator. Differential Revision: D78675986

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 21, 2025
@JacobSzwejbka @facebook-github-bot
Validate kTensorDimensionLimit (pytorch#12684)
03fbcef 
Summary:

Need to check this limit at deserialization since the ops rely on it

Reviewed By: larryliu0820

Differential Revision: D78675986
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 21, 2025
@JacobSzwejbka @facebook-github-bot
Validate kTensorDimensionLimit (pytorch#12684)
d483b5e 
Summary:

Need to check this limit at deserialization since the ops rely on it

Reviewed By: larryliu0820

Differential Revision: D78675986
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2025

This pull request was exported from Phabricator. Differential Revision: D78675986

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 21, 2025
@JacobSzwejbka @facebook-github-bot
Validate kTensorDimensionLimit (pytorch#12684)
aa17211 
Summary:

Need to check this limit at deserialization since the ops rely on it

Reviewed By: larryliu0820

Differential Revision: D78675986
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2025

This pull request was exported from Phabricator. Differential Revision: D78675986

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 21, 2025
@JacobSzwejbka @facebook-github-bot
Validate kTensorDimensionLimit (pytorch#12684)
b62d6a9 
Summary:

Need to check this limit at deserialization since the ops rely on it

Reviewed By: larryliu0820

Differential Revision: D78675986
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 21, 2025

This pull request was exported from Phabricator. Differential Revision: D78675986

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 22, 2025
@JacobSzwejbka @facebook-github-bot
Validate kTensorDimensionLimit (pytorch#12684)
2bda9f0 
Summary:

Need to check this limit at deserialization since the ops rely on it

Reviewed By: larryliu0820

Differential Revision: D78675986
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 22, 2025

This pull request was exported from Phabricator. Differential Revision: D78675986

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 22, 2025
@JacobSzwejbka @facebook-github-bot
Validate kTensorDimensionLimit (pytorch#12684)
fd7842c 
Summary:
Pull Request resolved: pytorch#12684

Need to check this limit at deserialization since the ops rely on it

Reviewed By: larryliu0820

Differential Revision: D78675986
@JacobSzwejbka @facebook-github-bot
Validate kTensorDimensionLimit (pytorch#12684)
f4872e6 
Summary:

Need to check this limit at deserialization since the ops rely on it

Reviewed By: larryliu0820

Differential Revision: D78675986
@facebook-github-bot facebook-github-bot merged commit cea9b23 into pytorch:main Jul 22, 2025
99 of 100 checks passed
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
@JacobSzwejbka @Conarnar
Validate kTensorDimensionLimit
aa24c92 
Differential Revision: D78675986

Pull Request resolved: pytorch#12684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@swolchok swolchok Awaiting requested review from swolchok

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JacobSzwejbka @facebook-github-bot @larryliu0820