Skip to content

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jul 21, 2025

Add a top level backends CMake target, which includes all configured backends. I validate this change by building a simple runner using the executorch_backends target and verifying that it was able to build and run an XNNPACK-delegated binary. Once the changes land in ExecuTorch, this will be long-term validated in executorch-examples CI.

To allow the executor runner target to use the executorch_backends target, I've also moved the Vulkan defs above the runner. This causes issues with the vulkan_executor_runner target, so I'm updating the main runner to include Vulkan and remove the Vulkan-specific one (subject to @SS-JIA's signoff).

This is done in the context of top-level CMake targets, tracked in #12293.

[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Jul 21, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12689

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit f7d413f with merge base 37e3003 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: b906c63
ghstack-comment-id: 3099241838
Pull-Request: #12689
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
@GregoryComer GregoryComer added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jul 21, 2025
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: 299c14f
ghstack-comment-id: 3099241838
Pull-Request: #12689
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer GregoryComer marked this pull request as ready for review July 22, 2025 05:03
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

Vulkan build failure in the unittest job is real. Fixing that and then this should be good to land.

[ghstack-poisoned]
@GregoryComer GregoryComer requested a review from SS-JIA July 24, 2025 23:43
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer GregoryComer merged commit 02e50cc into main Jul 28, 2025
99 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/81/head branch July 28, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants