Add top-level CMake backends target #12689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12689
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit f7d413f with merge base 37e3003 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
GregoryComer
added
the
release notes: build
This was referenced Jul 24, 2025
larryliu0820
approved these changes
Jul 24, 2025
|
Vulkan build failure in the unittest job is real. Fixing that and then this should be good to land. |
mergennachin
approved these changes
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a top level backends CMake target, which includes all configured backends. I validate this change by building a simple runner using the executorch_backends target and verifying that it was able to build and run an XNNPACK-delegated binary. Once the changes land in ExecuTorch, this will be long-term validated in executorch-examples CI.
To allow the executor runner target to use the executorch_backends target, I've also moved the Vulkan defs above the runner. This causes issues with the vulkan_executor_runner target, so I'm updating the main runner to include Vulkan and remove the Vulkan-specific one (subject to @SS-JIA's signoff).
This is done in the context of top-level CMake targets, tracked in #12293.