Skip to content

Conversation

pytorchbot
Copy link
Collaborator

Summary

Update the CMake version requirement to 3.29. This is in response to XNNPACK implicitly requiring it.

Note that it should be sufficient to update the dependency only at the top-level CMake (as opposed to all of the separate locations where the version in specified).

Fixes #12524. See the issue for more context.

Test plan

I've built locally to verify that it builds correctly. CI will also help validate. I also attempted to build with an older CMake version (3.28), and observed the following error:

CMake Error at CMakeLists.txt:50 (cmake_minimum_required):
  CMake 3.29 or higher is required.  You are running version 3.28.0

Previously, it would error out with:

CMake Error at CMakeLists.txt:18 (CMAKE_POLICY):
  Policy "CMP0156" is not known to this version of CMake.

### Summary
Update the CMake version requirement to 3.29. This is in response to
XNNPACK implicitly requiring it.

Note that it should be sufficient to update the dependency only at the
top-level CMake (as opposed to all of the separate locations where the
version in specified).

Fixes #12524. See the issue
for more context.

### Test plan
I've built locally to verify that it builds correctly. CI will also help
validate. I also attempted to build with an older CMake version (3.28),
and observed the following error:

```
CMake Error at CMakeLists.txt:50 (cmake_minimum_required):
  CMake 3.29 or higher is required.  You are running version 3.28.0
```

Previously, it would error out with:
```
CMake Error at CMakeLists.txt:18 (CMAKE_POLICY):
  Policy "CMP0156" is not known to this version of CMake.
```

(cherry picked from commit a1b35e8)
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12690

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs

As of commit d4ec7a6 with merge base de24489 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
@larryliu0820 larryliu0820 merged commit 82d763b into release/0.7 Jul 23, 2025
95 of 99 checks passed
@larryliu0820 larryliu0820 deleted the cherry-pick-12556-by-pytorch_bot_bot_ branch July 23, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants