Bump CMake requirement to 3.29 #12690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the CMake version requirement to 3.29. This is in response to XNNPACK implicitly requiring it.
Note that it should be sufficient to update the dependency only at the top-level CMake (as opposed to all of the separate locations where the version in specified).
Fixes #12524. See the issue for more context.
Test plan
I've built locally to verify that it builds correctly. CI will also help validate. I also attempted to build with an older CMake version (3.28), and observed the following error:
Previously, it would error out with: