Skip to content

Use Q_ANNOTATION_KEY #12728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Jul 25, 2025
Merged

Use Q_ANNOTATION_KEY #12728

facebook-github-bot merged 1 commit into from
Jul 25, 2025

Conversation

@cccclai
Copy link
Contributor

@cccclai cccclai commented Jul 22, 2025

Summary: pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12728

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 97a724f with merge base ef10a35 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 22, 2025

This pull request was exported from Phabricator. Differential Revision: D78193037

@github-actions
Copy link

github-actions bot commented Jul 22, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Jul 22, 2025
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
15eecbd 
Summary:

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@cccclai cccclai force-pushed the export-D78193037 branch from b9d6de8 to 15eecbd Compare July 22, 2025 23:49
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 22, 2025

This pull request was exported from Phabricator. Differential Revision: D78193037

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Jul 22, 2025
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
684fbdc 
Summary:
Pull Request resolved: pytorch#12728

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@cccclai cccclai force-pushed the export-D78193037 branch from 15eecbd to 684fbdc Compare July 22, 2025 23:53
cccclai added a commit to cccclai/executorch-1 that referenced this pull request Jul 23, 2025
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
62886b8 
Summary:

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@cccclai cccclai force-pushed the export-D78193037 branch from 684fbdc to 62886b8 Compare July 23, 2025 01:21
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 23, 2025

This pull request was exported from Phabricator. Differential Revision: D78193037

@cccclai cccclai requested a review from jerryzh168 July 23, 2025 01:21
@cccclai cccclai force-pushed the export-D78193037 branch from 62886b8 to 95de51a Compare July 23, 2025 21:52
cccclai added a commit to cccclai/executorch-1 that referenced this pull request Jul 23, 2025
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
95de51a 
Summary:

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 23, 2025

This pull request was exported from Phabricator. Differential Revision: D78193037

@digantdesai
Copy link
Contributor

digantdesai commented Jul 24, 2025 •
edited
Loading

Nit: s/Q_/QUANT_ for readability? even for pytorch/ao#2525

@cccclai
Copy link
Contributor Author

cccclai commented Jul 24, 2025

Nit: s/Q_/QUANT_ for readability? even for pytorch/ao#2525

Jerry suggested Q to avoid too much typing...

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Jul 24, 2025
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
c7db81f 
Summary:

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@cccclai cccclai force-pushed the export-D78193037 branch from 95de51a to c7db81f Compare July 24, 2025 17:35
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 24, 2025

This pull request was exported from Phabricator. Differential Revision: D78193037

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Jul 24, 2025
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
53d92e9 
Summary:

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@cccclai cccclai force-pushed the export-D78193037 branch from c7db81f to 53d92e9 Compare July 24, 2025 17:42
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
97a724f 
Summary:
Pull Request resolved: pytorch#12728

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 24, 2025

This pull request was exported from Phabricator. Differential Revision: D78193037

@cccclai cccclai force-pushed the export-D78193037 branch from 53d92e9 to 97a724f Compare July 24, 2025 17:47
@facebook-github-bot facebook-github-bot merged commit 3752b3a into pytorch:main Jul 25, 2025
95 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@mcr229 mcr229 Awaiting requested review from mcr229

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cccclai @facebook-github-bot @digantdesai