-
Notifications
You must be signed in to change notification settings - Fork 751
Fix qualcomm backend build failure #12751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jie Fu <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12751
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 507d908 with merge base 0b8d99f ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cccclai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Thanks @cccclai . |
|
Thanks @Gasoonjia . |
This fixes the build failure of qualcomm backend due to missing
including \<string\>.
```
[ 9%] Building C object backends/xnnpack/third-party/cpuinfo/CMakeFiles/cpuinfo.dir/src/x86/cache/init.c.o
In file included from /home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.cpp:8:
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:25:12: error: ‘std::string’ has not been declared
25 | bool Add(std::string qnn_op_name);
| ^~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:27:12: error: ‘std::string’ has not been declared
27 | bool Has(std::string qnn_op_name);
| ^~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:29:14: error: ‘std::string’ has not been declared
29 | bool Erase(std::string qnn_op_name);
| ^~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:34:27: error: ‘string’ is not a member of ‘std’
34 | std::unordered_set<std::string> qnn_op_package_path_set_;
| ^~~~~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:11:1: note: ‘std::string’ is defined in header ‘<string>’; did you forget to ‘#include <string>’?
10 | #include <unordered_set>
+++ |+#include <string>
11 |
```
---------
Signed-off-by: Jie Fu <[email protected]>
Co-authored-by: Gasoonjia <[email protected]>
This fixes the build failure of qualcomm backend due to missing including <string>.