Skip to content

Conversation

@DamonFool
Copy link
Contributor

@DamonFool DamonFool commented Jul 23, 2025

This fixes the build failure of qualcomm backend due to missing including <string>.

[  9%] Building C object backends/xnnpack/third-party/cpuinfo/CMakeFiles/cpuinfo.dir/src/x86/cache/init.c.o
In file included from /home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.cpp:8:
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:25:12: error: ‘std::string’ has not been declared
   25 |   bool Add(std::string qnn_op_name);
      |            ^~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:27:12: error: ‘std::string’ has not been declared
   27 |   bool Has(std::string qnn_op_name);
      |            ^~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:29:14: error: ‘std::string’ has not been declared
   29 |   bool Erase(std::string qnn_op_name);
      |              ^~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:34:27: error: ‘string’ is not a member of ‘std’
   34 |   std::unordered_set<std::string> qnn_op_package_path_set_;
      |                           ^~~~~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:11:1: note: ‘std::string’ is defined in header ‘<string>’; did you forget to ‘#include <string>’?
   10 | #include <unordered_set>
  +++ |+#include <string>
   11 | 

@DamonFool DamonFool requested a review from cccclai as a code owner July 23, 2025 12:54
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12751

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 507d908 with merge base 0b8d99f (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2025
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DamonFool
Copy link
Contributor Author

Thanks @cccclai .
I just pushed one more commit to fix the lintrunner check failure.
Please review again.

@Gasoonjia Gasoonjia added the release notes: none Do not include this in the release notes label Jul 24, 2025
@Gasoonjia Gasoonjia merged commit 6df857f into pytorch:main Jul 24, 2025
95 of 100 checks passed
@DamonFool
Copy link
Contributor Author

Thanks @Gasoonjia .

@DamonFool DamonFool deleted the qualcom-build-failure branch July 24, 2025 06:03
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
This fixes the build failure of qualcomm backend due to missing
including \<string\>.

```
[  9%] Building C object backends/xnnpack/third-party/cpuinfo/CMakeFiles/cpuinfo.dir/src/x86/cache/init.c.o
In file included from /home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.cpp:8:
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:25:12: error: ‘std::string’ has not been declared
   25 |   bool Add(std::string qnn_op_name);
      |            ^~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:27:12: error: ‘std::string’ has not been declared
   27 |   bool Has(std::string qnn_op_name);
      |            ^~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:29:14: error: ‘std::string’ has not been declared
   29 |   bool Erase(std::string qnn_op_name);
      |              ^~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:34:27: error: ‘string’ is not a member of ‘std’
   34 |   std::unordered_set<std::string> qnn_op_package_path_set_;
      |                           ^~~~~~
/home/jiefu/executorch/backends/qualcomm/runtime/backends/QnnOpPackageManager.h:11:1: note: ‘std::string’ is defined in header ‘<string>’; did you forget to ‘#include <string>’?
   10 | #include <unordered_set>
  +++ |+#include <string>
   11 | 
```

---------

Signed-off-by: Jie Fu <[email protected]>
Co-authored-by: Gasoonjia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants