Skip to content

Disable torchao kernels by default #12779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2025
Merged

Disable torchao kernels by default #12779

merged 3 commits into from
Jul 24, 2025

Conversation

metascroy
Copy link
Contributor

@metascroy metascroy commented Jul 23, 2025 •
edited
Loading

This PR disables building torchao kernels from source by default.

To enable the builds, a user needs to explicitly define the environment variable USE_CPP=1:

EXECUTORCH_BUILD_TORCHAO=1 python install_executorch.py

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12779

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5d218ff with merge base 503db13 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy metascroy requested a review from mergennachin July 23, 2025 21:38
@mergennachin mergennachin mentioned this pull request Jul 23, 2025
Closed
@metascroy metascroy merged commit e81727a into main Jul 24, 2025
199 checks passed
@metascroy metascroy deleted the disable-torchao-kernel-build-by-default branch July 24, 2025 00:05
@metascroy
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.7 -c critical

pytorchbot pushed a commit that referenced this pull request Jul 24, 2025
@metascroy @pytorchbot
Disable torchao kernels by default (#12779)
70173c5 
This PR disables building torchao kernels from source by default.

To enable the builds, a user needs to explicitly define the environment
variable USE_CPP=1:

```
EXECUTORCH_BUILD_TORCHAO=1 python install_executorch.py
```

(cherry picked from commit e81727a)
@pytorchbot
Copy link
Collaborator

Cherry picking #12779

The cherry pick PR is at #12794 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Jul 24, 2025
Closed
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
@metascroy @Conarnar
Disable torchao kernels by default (pytorch#12779)
e411284 
This PR disables building torchao kernels from source by default.

To enable the builds, a user needs to explicitly define the environment
variable USE_CPP=1:

```
EXECUTORCH_BUILD_TORCHAO=1 python install_executorch.py
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@metascroy @pytorchbot @mergennachin @facebook-github-bot