Skip to content

integrate IOManager with runner #12793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Jul 25, 2025
Merged

integrate IOManager with runner #12793

facebook-github-bot merged 1 commit into from
Jul 25, 2025

Conversation

@JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Jul 24, 2025

Summary: Add to the runner code. The runner doesn't distinguish between decode and prefill today, but we can pipe that info down in a later diff

Differential Revision: D78499456

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12793

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3039bf0 with merge base f332196 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 24, 2025

This pull request was exported from Phabricator. Differential Revision: D78499456

@github-actions
Copy link

github-actions bot commented Jul 24, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 24, 2025
@JacobSzwejbka @facebook-github-bot
integrate with runner (pytorch#12793)
492616d 
Summary:

Add to the runner code. The runner doesn't distinguish between decode and prefill today, but we can pipe that info down in a later diff

Differential Revision: D78499456
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 24, 2025

This pull request was exported from Phabricator. Differential Revision: D78499456

@mergennachin mergennachin changed the title integrate with runner integrate IOManager with runner Jul 24, 2025
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 24, 2025
@JacobSzwejbka @facebook-github-bot
integrate with runner (pytorch#12793)
d0e12ae 
Summary:

Add to the runner code. The runner doesn't distinguish between decode and prefill today, but we can pipe that info down in a later diff

Reviewed By: larryliu0820, mergennachin

Differential Revision: D78499456
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 24, 2025

This pull request was exported from Phabricator. Differential Revision: D78499456

@JacobSzwejbka @facebook-github-bot
integrate with runner (pytorch#12793)
3039bf0 
Summary:

Add to the runner code. The runner doesn't distinguish between decode and prefill today, but we can pipe that info down in a later diff

bypass-pytorch-oss-checks

Reviewed By: larryliu0820, mergennachin

Differential Revision: D78499456
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 25, 2025

This pull request was exported from Phabricator. Differential Revision: D78499456

@facebook-github-bot facebook-github-bot merged commit 2120135 into pytorch:main Jul 25, 2025
107 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@swolchok swolchok Awaiting requested review from swolchok

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JacobSzwejbka @facebook-github-bot @mergennachin @larryliu0820