-
Notifications
You must be signed in to change notification settings - Fork 685
Distribute jobs to multiple private device pools #12832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Huy Do <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12832
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 7384b78 with merge base 0479dcd ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Signed-off-by: Huy Do <[email protected]>
Let me take a look at the failures from https://github.com/pytorch/executorch/actions/runs/16513751841/job/46701693809 before landing this. I wasn't expect to see them there |
Summary
We want to distribute jobs to multiple private device pools now that we have have more private devices on AWS mainly:
A simple round-robin distribution algorithm will allocate different benchmark configs to devices of the same type from different pools. To achieve this, I refactor
.ci/scripts/gather_benchmark_configs.py
to introduce the concept of device variant in which the device name will be in the formatDEVICE_NAME+VARIANT
, for examplesamsung_galaxy_s22+private
orapple_iphone_15+ios_18_public
. Each can have more than one device pools.I also re-enable the benchmark jobs on private iOS devices now that we have more of them to use.
Test plan
samsung_galaxy_s22+private
: https://github.com/pytorch/executorch/actions/runs/16509295068apple_iphone_15+pro_private
: https://github.com/pytorch/executorch/actions/runs/16513651804pytest .ci/script/test_generate_vllm_benchmark_matrix.py