Extend `PyBundledModule` with `extension.BundledModule` #12839

Gasoonjia · 2025-07-25T00:16:30Z

Differential Revision: D78938344

pytorch-bot · 2025-07-25T00:16:33Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12839

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 1125d78 with merge base ecb639a ():

NEW FAILURE - The following job has failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-07-25T00:16:43Z

This pull request was exported from Phabricator. Differential Revision: D78938344

github-actions · 2025-07-25T00:17:15Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-07-25T07:34:17Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-07-25T18:08:08Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-07-29T18:46:30Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-07-29T19:54:39Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-07-29T20:35:18Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-07-29T22:41:56Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-07-29T23:49:47Z

This pull request was exported from Phabricator. Differential Revision: D78938344

facebook-github-bot · 2025-08-12T23:33:05Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-08-13T00:31:53Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-08-13T06:14:43Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-08-13T07:09:26Z

This pull request was exported from Phabricator. Differential Revision: D78938344

lucylq · 2025-08-14T22:54:44Z

CMakeLists.txt

 )

+# Build devtools first if needed - some backends depend on protobuf from
+# devtools


Can you specify which backends require this? :0

Can we try move this before line 426, if(EXECUTORCH_BUILD_PYBIND AND APPLE), the error in apple pybindings seems to be related to protobuf.

executorch/CMakeLists.txt

Line 426 in 365d4c1

if(EXECUTORCH_BUILD_PYBIND AND APPLE)

CMake Error at backends/apple/coreml/CMakeLists.txt:215 (add_subdirectory): add_subdirectory given source "/Users/runner/work/executorch/executorch/pytorch/executorch/backends/apple/coreml/third-party/coremltools/deps/protobuf/cmake" which is not an existing directory. CMake Error at tools/cmake/Utils.cmake:36 (target_link_options): Cannot specify link options for target "libprotobuf-lite" which is not built by this project. Call Stack (most recent call first): tools/cmake/Utils.cmake:54 (executorch_macos_kernel_link_options) backends/apple/coreml/CMakeLists.txt:219 (executorch_target_link_options_shared_lib) CMake Error at backends/apple/coreml/CMakeLists.txt:246 (target_compile_options): Cannot specify compile options for target "libprotobuf-lite" which is not built by this project.

reasonable point! Let me try that

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-08-14T23:22:36Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

facebook-github-bot · 2025-08-14T23:47:11Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Reviewed By: lucylq Differential Revision: D78938344

facebook-github-bot · 2025-08-15T00:31:00Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Reviewed By: lucylq Differential Revision: D78938344

facebook-github-bot · 2025-08-15T03:20:16Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Summary: Pull Request resolved: pytorch#12839 Reviewed By: lucylq Differential Revision: D78938344

facebook-github-bot · 2025-08-15T04:35:01Z

This pull request was exported from Phabricator. Differential Revision: D78938344

Differential Revision: D78938344 Pull Request resolved: pytorch#12839

Gasoonjia requested review from JacobSzwejbka, kirklandsign and larryliu0820 as code owners July 25, 2025 00:16

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jul 25, 2025

Gasoonjia force-pushed the export-D78938344 branch from 4a1223c to cc581ed Compare July 25, 2025 07:34

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jul 25, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

cc581ed

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jul 25, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

9a1a608

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from cc581ed to 9a1a608 Compare July 25, 2025 18:07

Gasoonjia force-pushed the export-D78938344 branch from 9a1a608 to 97617ff Compare July 29, 2025 18:46

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jul 29, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

97617ff

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jul 29, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

9f30a76

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from 97617ff to 9f30a76 Compare July 29, 2025 19:54

Gasoonjia force-pushed the export-D78938344 branch from 9f30a76 to 7b0c4ee Compare July 29, 2025 20:35

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jul 29, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

7b0c4ee

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jul 29, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

6bd6ef4

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from 7b0c4ee to 6bd6ef4 Compare July 29, 2025 22:41

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jul 29, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

7036236

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from 6bd6ef4 to 7036236 Compare July 29, 2025 23:49

Gasoonjia force-pushed the export-D78938344 branch from 7036236 to 232278c Compare July 30, 2025 19:58

Gasoonjia force-pushed the export-D78938344 branch from 6a89df7 to 0da468b Compare August 12, 2025 23:32

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Aug 13, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

69b6eaa

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from 0da468b to 69b6eaa Compare August 13, 2025 00:31

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Aug 13, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

9c857da

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from 69b6eaa to 9c857da Compare August 13, 2025 06:14

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Aug 13, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

fb5132a

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from 9c857da to fb5132a Compare August 13, 2025 07:09

lucylq reviewed Aug 14, 2025

View reviewed changes

Gasoonjia force-pushed the export-D78938344 branch from fb5132a to a976302 Compare August 14, 2025 23:22

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Aug 14, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

a976302

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Aug 14, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

47e65b7

Summary: Pull Request resolved: pytorch#12839 Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from a976302 to 47e65b7 Compare August 14, 2025 23:46

lucylq approved these changes Aug 14, 2025

View reviewed changes

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Aug 15, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

f32194f

Summary: Pull Request resolved: pytorch#12839 Reviewed By: lucylq Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from 47e65b7 to f32194f Compare August 15, 2025 00:30

Gasoonjia force-pushed the export-D78938344 branch from f32194f to 9b3f8c0 Compare August 15, 2025 03:20

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Aug 15, 2025

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

9b3f8c0

Summary: Pull Request resolved: pytorch#12839 Reviewed By: lucylq Differential Revision: D78938344

Extend PyBundledModule with extension.BundledModule (pytorch#12839)

1125d78

Summary: Pull Request resolved: pytorch#12839 Reviewed By: lucylq Differential Revision: D78938344

Gasoonjia force-pushed the export-D78938344 branch from 9b3f8c0 to 1125d78 Compare August 15, 2025 04:34

facebook-github-bot merged commit 1b4968f into pytorch:main Aug 15, 2025
102 of 106 checks passed

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025

Extend PyBundledModule with extension.BundledModule

881bd12

Differential Revision: D78938344 Pull Request resolved: pytorch#12839

Extend PyBundledModule with extension.BundledModule #12839

Extend PyBundledModule with extension.BundledModule #12839

Uh oh!

Conversation

Gasoonjia commented Jul 25, 2025

Uh oh!

pytorch-bot bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12839

❌ 1 New Failure

Uh oh!

facebook-github-bot commented Jul 25, 2025

Uh oh!

github-actions bot commented Jul 25, 2025

This PR needs a release notes: label

Uh oh!

facebook-github-bot commented Jul 25, 2025

Uh oh!

facebook-github-bot commented Jul 25, 2025

Uh oh!

facebook-github-bot commented Jul 29, 2025

Uh oh!

facebook-github-bot commented Jul 29, 2025

Uh oh!

facebook-github-bot commented Jul 29, 2025

Uh oh!

facebook-github-bot commented Jul 29, 2025

Uh oh!

facebook-github-bot commented Jul 29, 2025

Uh oh!

facebook-github-bot commented Aug 12, 2025

Uh oh!

facebook-github-bot commented Aug 13, 2025

Uh oh!

facebook-github-bot commented Aug 13, 2025

Uh oh!

facebook-github-bot commented Aug 13, 2025

Uh oh!

lucylq Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gasoonjia Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 14, 2025

Uh oh!

facebook-github-bot commented Aug 14, 2025

Uh oh!

facebook-github-bot commented Aug 15, 2025

Uh oh!

facebook-github-bot commented Aug 15, 2025

Uh oh!

facebook-github-bot commented Aug 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Extend `PyBundledModule` with `extension.BundledModule` #12839

Extend `PyBundledModule` with `extension.BundledModule` #12839

pytorch-bot bot commented Jul 25, 2025 •

edited

Loading

This PR needs a `release notes:` label

lucylq Aug 14, 2025 •

edited

Loading