Skip to content

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jul 25, 2025

Add tests for a view-type ops, cat, and slice.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12851

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 93 Pending

As of commit 0c873ab with merge base 64d8223 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer GregoryComer requested a review from digantdesai July 29, 2025 05:52
@GregoryComer GregoryComer marked this pull request as ready for review July 29, 2025 05:53
@GregoryComer GregoryComer requested a review from cccclai as a code owner July 29, 2025 05:53
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming you have some way to figure out "how to test" in terms of coverage and which tests to add for these ops.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/GregoryComer/97/head to main July 29, 2025 17:52
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

I am assuming you have some way to figure out "how to test" in terms of coverage and which tests to add for these ops.

My methodology isn't super rigorous, but I am intending to cover all relevant portions of the user-facing torch API surface, under torch.nn, torch.nn.functional, and tensor ops. I've generated the list of ops to test from inspecting the docs: https://docs.pytorch.org/docs/stable/torch.html. I'm definitely open to suggestions.

I prefer the user-facing surface over the core opset directly, in part because the wrapper modules can sometimes transform inputs in certain ways or enforce certain constraints that the backends often expect. Ideally, the backends would handle the full op-set space, but this was a common source of noise in the facto tests. The backend fails on some raw op inputs that cannot be generated through the nn.Module or similar.

@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jul 29, 2025
@GregoryComer GregoryComer merged commit 0479dcd into main Jul 29, 2025
100 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/98/head branch July 29, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants