Skip to content

Evalue** -> Span #12908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Jul 29, 2025
Merged

Evalue** -> Span #12908

facebook-github-bot merged 1 commit into from
Jul 29, 2025

Conversation

@JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Jul 28, 2025

Summary: We want to add safety checks inside the kernels on the amount of args they have received. To do that we need a pointer and a length instead of just a pointer. So swapping to span fixes that.

Differential Revision: D78904269

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12908

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 87f8c5a with merge base 9d92ff8 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2025

This pull request was exported from Phabricator. Differential Revision: D78904269

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jul 28, 2025
@github-actions
Copy link

github-actions bot commented Jul 28, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 28, 2025
@JacobSzwejbka @facebook-github-bot
Evalue** -> Span (pytorch#12908)
44eaad7 
Summary:

We want to add safety checks inside the kernels on the amount of args they have received. To do that we need a pointer and a length instead of just a pointer. So swapping to span fixes that.

Differential Revision: D78904269
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2025

This pull request was exported from Phabricator. Differential Revision: D78904269

larryliu0820
larryliu0820 approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 28, 2025
@JacobSzwejbka @facebook-github-bot
Evalue** -> Span (pytorch#12908)
98f6832 
Summary:

We want to add safety checks inside the kernels on the amount of args they have received. To do that we need a pointer and a length instead of just a pointer. So swapping to span fixes that.

Reviewed By: larryliu0820

Differential Revision: D78904269
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2025

This pull request was exported from Phabricator. Differential Revision: D78904269

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 28, 2025
@JacobSzwejbka @facebook-github-bot
Evalue** -> Span (pytorch#12908)
c188356 
Summary:

We want to add safety checks inside the kernels on the amount of args they have received. To do that we need a pointer and a length instead of just a pointer. So swapping to span fixes that.

Reviewed By: larryliu0820

Differential Revision: D78904269
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2025

This pull request was exported from Phabricator. Differential Revision: D78904269

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 28, 2025
@JacobSzwejbka @facebook-github-bot
Evalue** -> Span (pytorch#12908)
91e5996 
Summary:

We want to add safety checks inside the kernels on the amount of args they have received. To do that we need a pointer and a length instead of just a pointer. So swapping to span fixes that.

Reviewed By: larryliu0820

Differential Revision: D78904269
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2025

This pull request was exported from Phabricator. Differential Revision: D78904269

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Jul 28, 2025
@JacobSzwejbka @facebook-github-bot
Evalue** -> Span (pytorch#12908)
eaea3f4 
Summary:

We want to add safety checks inside the kernels on the amount of args they have received. To do that we need a pointer and a length instead of just a pointer. So swapping to span fixes that.

Reviewed By: larryliu0820

Differential Revision: D78904269
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2025

This pull request was exported from Phabricator. Differential Revision: D78904269

@JacobSzwejbka @facebook-github-bot
Evalue** -> Span (pytorch#12908)
87f8c5a 
Summary:

We want to add safety checks inside the kernels on the amount of args they have received. To do that we need a pointer and a length instead of just a pointer. So swapping to span fixes that.

Reviewed By: larryliu0820

Differential Revision: D78904269
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 28, 2025

This pull request was exported from Phabricator. Differential Revision: D78904269

@facebook-github-bot facebook-github-bot merged commit 72bb4f4 into pytorch:main Jul 29, 2025
98 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@swolchok swolchok Awaiting requested review from swolchok

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JacobSzwejbka @facebook-github-bot @larryliu0820