Skip to content

[Executorch][Export][2/N] Add to_edge and to_backend stages #12937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 1, 2025
Merged

[Executorch][Export][2/N] Add to_edge and to_backend stages #12937

merged 4 commits into from
Aug 1, 2025

Conversation

abhinaykukkadapu
Copy link
Contributor

@abhinaykukkadapu abhinaykukkadapu commented Jul 28, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Address (6) in the rfc: #12660

  1. Adds stage implementations for to_edge and to_backend
  2. Adds unit tests for the two stages
  3. Adds these two stages in the validation pipeline.

Fixes #12932

Differential Revision: D79120576

@abhinaykukkadapu
[Executorch][Export][2/N] Add to_edge and to_backend stages
36daa0d 
Address (6) in the rfc: #12660

1. Adds stage implementations for `to_edge` and `to_backend`
2. Adds unit tests for the two stages
3. Adds these two stages in the validation pipeline.

Fixes #12932

Differential Revision: [D79120576](https://our.internmc.facebook.com/intern/diff/D79120576/)

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12937

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 22 Pending

As of commit 9165f44 with merge base f497f7f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jul 28, 2025
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79120576

@abhinaykukkadapu
Update on "[Executorch][Export][2/N] Add to_edge and to_backend stages"
a70f039 
Address (6) in the rfc: #12660

1. Adds stage implementations for `to_edge` and `to_backend`
2. Adds unit tests for the two stages
3. Adds these two stages in the validation pipeline.

Fixes #12932

Differential Revision: [D79120576](https://our.internmc.facebook.com/intern/diff/D79120576/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79120576

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

digantdesai
digantdesai reviewed Jul 31, 2025
View reviewed changes
export/stages.py

@property
def valid_predecessor_stages(self) -> List["StageType"]:
return [StageType.TO_EDGE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm I see this here :)

digantdesai
digantdesai approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhinaykukkadapu
Update on "[Executorch][Export][2/N] Add to_edge and to_backend stages"
f18ddc2 
Address (6) in the rfc: #12660

1. Adds stage implementations for `to_edge` and `to_backend`
2. Adds unit tests for the two stages
3. Adds these two stages in the validation pipeline.

Fixes #12932

Differential Revision: [D79120576](https://our.internmc.facebook.com/intern/diff/D79120576/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79120576

@abhinaykukkadapu
Update on "[Executorch][Export][2/N] Add to_edge and to_backend stages"
9165f44 
Address (6) in the rfc: #12660

1. Adds stage implementations for `to_edge` and `to_backend`
2. Adds unit tests for the two stages
3. Adds these two stages in the validation pipeline.

Fixes #12932

Differential Revision: [D79120576](https://our.internmc.facebook.com/intern/diff/D79120576/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79120576

@facebook-github-bot facebook-github-bot merged commit d35b8ce into gh/abhinaykukkadapu/2/base Aug 1, 2025
101 of 104 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/abhinaykukkadapu/2/head branch August 1, 2025 05:31
@pytorchbot pytorchbot mentioned this pull request Aug 1, 2025
Merged
Gasoonjia pushed a commit that referenced this pull request Aug 1, 2025
@pytorchbot @abhinaykukkadapu
[Executorch][Export][2/N] Add to_edge and to_backend stages (#13056)
c97b129 
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #12937 by
@abhinaykukkadapu
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/abhinaykukkadapu/2/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/abhinaykukkadapu/2/head
Merge bot PR base:
https://github.com/pytorch/executorch/tree/gh/abhinaykukkadapu/1/orig
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/abhinaykukkadapu/2/orig
@diff-train-skip-merge

Co-authored-by: Abhinay Kukkadapu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@larryliu0820 larryliu0820 larryliu0820 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinaykukkadapu @facebook-github-bot @digantdesai @larryliu0820