-
Notifications
You must be signed in to change notification settings - Fork 752
Arm backend: Use correct name when indexing state_dict #12954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: I60c8f503f60fc25dce0c9e040a8b02429825c20c Signed-off-by: Sebastian Larsson <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12954
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit fd9f7a5 with merge base b0dda93 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
CI failures seem unrelated |
| rank = node.meta["val"].dim() | ||
| if rank == 0: | ||
| if not self._is_inputs_to_buffers_or_parameters(node): | ||
| if is_buffer(self.exported_program, node): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit make a util def get_name(self, node)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Local to this file? Seems a little redundant to me, I suppose that would look something like this
def get_name(self, node):
if is_buffer(self.exported_program, node):
return self.exported_program.graph_signature.inputs_to_buffers[node.name]
# Reapeat for param etc.
...
And this is done 2 times only.
I think it would belong in torch._export.utils like is_buffer etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even local would make it cleaner. Feel free to put up a PR against _export.utils if you feel like others are doing this or should do it this way.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218