Skip to content

Conversation

@Sebastian-Larsson
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented Jul 29, 2025

Change-Id: I60c8f503f60fc25dce0c9e040a8b02429825c20c
Signed-off-by: Sebastian Larsson <[email protected]>
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Jul 29, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12954

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit fd9f7a5 with merge base b0dda93 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2025
@Sebastian-Larsson
Copy link
Collaborator Author

CI failures seem unrelated

rank = node.meta["val"].dim()
if rank == 0:
if not self._is_inputs_to_buffers_or_parameters(node):
if is_buffer(self.exported_program, node):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit make a util def get_name(self, node)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local to this file? Seems a little redundant to me, I suppose that would look something like this

def get_name(self, node):
     if is_buffer(self.exported_program, node):
         return self.exported_program.graph_signature.inputs_to_buffers[node.name]
     # Reapeat for param etc.
     ...

And this is done 2 times only.

I think it would belong in torch._export.utils like is_buffer etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even local would make it cleaner. Feel free to put up a PR against _export.utils if you feel like others are doing this or should do it this way.

@AdrianLundell AdrianLundell merged commit 275adee into pytorch:main Jul 30, 2025
211 of 214 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants