-
Notifications
You must be signed in to change notification settings - Fork 753
Arm backend: Move the portable kernels section to bigger memory #12955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Move the portable kernels section to bigger memory #12955
Conversation
This patch moves the portable kernels from the ITCM to the BRAM so that we don't overflow on the ITCM when linking the application Change-Id: Ib6dd5fc97a0fa1138b7702cb23052a7015ff4135
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12955
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 51d8fbd with merge base b0dda93 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
digantdesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is OK. FWIW, we added PTE based dtype selective build, in addition to existing per op selective build to further reduce the size of these op_*_cpp.obj files :)
FYI @BujSet
Sebastian-Larsson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated CI errors. Approved
|
@GeorgeARM do we need this also for CS320 for U85? |
|
On the CS320, the .text section is stored in the BRAM and we have 2MB of BRAM, so we haven't seen link time failures due to building with more portable kernels. |
This patch moves the portable kernels from the ITCM to the BRAM so that we don't overflow on the ITCM when linking the application
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218