Extend op_add for complex dtype #12977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12977
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit e0b07d8 with merge base e19e4a7 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79091064 |
pssrawat
force-pushed
the
export-D79091064
branch
from
18eb723 to
32ae2db
Compare
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Jul 31, 2025
Summary: Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Differential Revision: D79091064
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79091064 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79091064 |
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Jul 31, 2025
Summary: Pull Request resolved: pytorch#12977 Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Differential Revision: D79091064
pssrawat
force-pushed
the
export-D79091064
branch
from
32ae2db to
1069587
Compare
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Jul 31, 2025
Summary: Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Differential Revision: D79091064
pssrawat
force-pushed
the
export-D79091064
branch
from
1069587 to
5d35bb1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79091064 |
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Jul 31, 2025
Summary: Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Differential Revision: D79091064
pssrawat
force-pushed
the
export-D79091064
branch
from
5d35bb1 to
967900c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79091064 |
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Jul 31, 2025
Summary: Pull Request resolved: pytorch#12977 Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Differential Revision: D79091064
pssrawat
force-pushed
the
export-D79091064
branch
from
967900c to
211cacc
Compare
manuelcandales
approved these changes
Aug 1, 2025
pssrawat
force-pushed
the
export-D79091064
branch
from
211cacc to
c93a394
Compare
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Aug 1, 2025
Summary: Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Reviewed By: manuelcandales Differential Revision: D79091064
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79091064 |
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Aug 1, 2025
Summary: Pull Request resolved: pytorch#12977 Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Reviewed By: manuelcandales Differential Revision: D79091064
pssrawat
force-pushed
the
export-D79091064
branch
from
c93a394 to
709a246
Compare
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Aug 2, 2025
Summary: Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Reviewed By: manuelcandales Differential Revision: D79091064
pssrawat
force-pushed
the
export-D79091064
branch
from
709a246 to
e4911ee
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79091064 |
pssrawat
added a commit
to pssrawat/executorch
that referenced
this pull request
Aug 2, 2025
Summary: Pull Request resolved: pytorch#12977 Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Reviewed By: manuelcandales Differential Revision: D79091064
pssrawat
force-pushed
the
export-D79091064
branch
from
e4911ee to
c8b75f2
Compare
Summary: Add complex dtype support for op_add. The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future. For optimized add op: Additionally, we do not support broadcasting. Reviewed By: manuelcandales Differential Revision: D79091064
pssrawat
force-pushed
the
export-D79091064
branch
from
c8b75f2 to
e0b07d8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79091064 |
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Differential Revision: D79091064 Pull Request resolved: pytorch#12977
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add complex dtype support for op_add.
The current support for complex dtype enforces that input and output tensors have the same dtype. Support mixed dtypes in the future.
For optimized add op: Additionally, we do not support broadcasting.
Differential Revision: D79091064