Skip to content

add safety check to prim kernels #12987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

add safety check to prim kernels #12987

merged 1 commit into from
Jul 30, 2025

Conversation

@JacobSzwejbka
Copy link
Contributor

@JacobSzwejbka JacobSzwejbka commented Jul 29, 2025

Summary: Just safety checking that we have as many args as we expected

Differential Revision: D79124770

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 29, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12987

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3b160b9 with merge base fb03b6f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 29, 2025

This pull request was exported from Phabricator. Differential Revision: D79124770

@github-actions
Copy link

github-actions bot commented Jul 29, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JacobSzwejbka @facebook-github-bot
add safety check to prim kernels (pytorch#12987)
3b160b9 
Summary:

Just safety checking that we have as many args as we expected

Differential Revision: D79124770
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 30, 2025

This pull request was exported from Phabricator. Differential Revision: D79124770

@facebook-github-bot facebook-github-bot merged commit b6b7a16 into pytorch:main Jul 30, 2025
102 of 103 checks passed
@zingo
Copy link
Collaborator

zingo commented Jul 31, 2025

This PR could have broken the cortex-m size test :( https://github.com/pytorch/executorch/actions/runs/16613951268/job/47002649711

@zingo
Copy link
Collaborator

zingo commented Jul 31, 2025

Tried to trigger a trunk build but it not triggering the builds after the PR is merged (and that makes sense :) )

digantdesai added a commit that referenced this pull request Aug 1, 2025
@digantdesai
Cortex-m Size bump by 1.5KiB
f84dd2d 
Tiny (236b) overflow after #12987 which adds safety related checks.

Failure - https://github.com/pytorch/executorch/actions/runs/16622225895/job/47029216900#step:15:17147
@digantdesai digantdesai mentioned this pull request Aug 1, 2025
Merged
larryliu0820 pushed a commit that referenced this pull request Aug 4, 2025
@digantdesai
Cortex-m Size bump by 1.5KiB (#13064)
ea16842 
Tiny (236b) overflow after #12987 which adds safety related checks.

Failure -
https://github.com/pytorch/executorch/actions/runs/16622225895/job/47029216900#step:15:17147
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@digantdesai @agrima1304
Cortex-m Size bump by 1.5KiB (pytorch#13064)
2dfd2af 
Tiny (236b) overflow after pytorch#12987 which adds safety related checks.

Failure -
https://github.com/pytorch/executorch/actions/runs/16622225895/job/47029216900#step:15:17147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

@swolchok swolchok Awaiting requested review from swolchok

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JacobSzwejbka @facebook-github-bot @zingo @GregoryComer