Skip to content

Conversation

@perheld
Copy link
Collaborator

@perheld perheld commented Jul 30, 2025

Prior to this patch, temporary tensors/buffers were used to hold the input data which was then copied over to the actual input tensors for running the inference. This patch removes this copying by instead writing the input data directly to the input tensors.

Change-Id: I20565a67dea8d8070efe9593aff4796c54e5fe90
Signed-off-by: [email protected]

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@perheld perheld requested a review from digantdesai as a code owner July 30, 2025 12:14
@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Jul 30, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12992

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 4082ceb with merge base 9f8c2f6 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2025
Prior to this patch, temporary tensors/buffers were used to hold the
input data which was then copied over to the actual input tensors for
running the inference. This patch removes this copying by instead
writing the input data directly to the input tensors.

Change-Id: I20565a67dea8d8070efe9593aff4796c54e5fe90
Signed-off-by: [email protected]
@perheld perheld force-pushed the ph-martin-things branch from e689661 to 4082ceb Compare July 30, 2025 12:14
@perheld perheld added the release notes: none Do not include this in the release notes label Jul 30, 2025
@perheld
Copy link
Collaborator Author

perheld commented Jul 31, 2025

https://github.com/pytorch/executorch/actions/runs/16622225895/job/47029216900 seems the size has gone above the threshold of 109000 resulting in "Fail 109236 > 109000". I dont know where the threshold value is coming from.

@perheld
Copy link
Collaborator Author

perheld commented Jul 31, 2025

https://github.com/pytorch/executorch/actions/runs/16622225895/job/47029216900 seems the size has gone above the threshold of 109000 resulting in "Fail 109236 > 109000". I dont know where the threshold value is coming from.

Seems the threshold was increased a bit in 69f3da0e332 by @swolchok just a few days ago.

@zingo
Copy link
Collaborator

zingo commented Jul 31, 2025

mac os fails also unrelated

@zingo zingo merged commit 308cad0 into pytorch:main Jul 31, 2025
222 of 225 checks passed
@digantdesai
Copy link
Contributor

I dont know where the threshold value is coming from

Arbitrary, this is to keep large, unintended size increases to sneak past without getting noticed. I can bump it again.

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
)

Prior to this patch, temporary tensors/buffers were used to hold the
input data which was then copied over to the actual input tensors for
running the inference. This patch removes this copying by instead
writing the input data directly to the input tensors.

Signed-off-by: [email protected]


cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Signed-off-by: [email protected]
Co-authored-by: Martin Lindström <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants