Skip to content

Conversation

@BujSet
Copy link
Contributor

@BujSet BujSet commented Jul 30, 2025

Summary

Similar to #12734, this PR includes testing the whisper-tiny encoder and decoder in succession.

Test plan

Adds the whisper_tiny entry to the models matrix for the test-models-arm-zephyr trunk test.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13008

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 17a38b9 with merge base bedce91 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@BujSet BujSet self-assigned this Jul 30, 2025
@BujSet
Copy link
Contributor Author

BujSet commented Jul 30, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jul 30, 2025
@BujSet BujSet added module: ci Issues related to continuous integration ciflow/trunk module: microcontrollers For embedded MCUs like Cortex-M, or RTOS like Zephyr, does not track NPU backend like Arm Ethos. and removed release notes: none Do not include this in the release notes labels Jul 30, 2025
@BujSet BujSet force-pushed the zephyr_ci_whisper_test branch 2 times, most recently from 7904a8b to 62c81b4 Compare July 31, 2025 03:13
@BujSet BujSet force-pushed the zephyr_ci_whisper_test branch from 7163311 to 17a38b9 Compare July 31, 2025 04:50
download_arm_zephyr_sdk
./zephyr-sdk-0.16.0/setup.sh -c -t arm-zephyr-eabi
SIM_LIMIT=120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Suggested change
SIM_LIMIT=120
SIM_LIMIT_SECONDS=120

if [[ "${MODEL_NAME}" == "whisper_tiny" ]]; then
cd $ZEPHYR_PROJ_ROOT
# For whisper-tiny, we will use optimum to export the encoder and decoder ptes
#OPTIMUM_ET_COMMIT=$(cat .ci/docker/ci_commit_pins/optimum-executorch.txt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove or use?

Comment on lines +118 to +120
pwd
ls
ls oa_whisper/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed?

Comment on lines +136 to +137
fi
if [[ "${MODEL_NAME}" == "whisper_tiny" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif

exit $exit_status
fi
if [[ "${MODEL_NAME}" == "whisper_tiny" ]]; then
python3 build_model.py --pte-file $ZEPHYR_PROJ_ROOT/oa_whisper/decoder.pte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking error code for encode?

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

west build -p always -b mps3/corstone300/fvp
FVP_Corstone_SSE-300_Ethos-U55 -a build/zephyr/zephyr.elf -C mps3_board.visualisation.disable-visualisation=1 -C mps3_board.telnetterminal0.start_telnet=0 -C mps3_board.uart0.out_file='sim.out' -C cpu0.CFGITCMSZ=15 -C cpu0.CFGDTCMSZ=15 --simlimit $SIM_LIMIT
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking error code for decode?

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: ci Issues related to continuous integration module: microcontrollers For embedded MCUs like Cortex-M, or RTOS like Zephyr, does not track NPU backend like Arm Ethos. stale PRs inactive for over 60 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants