- Move register backend logic to its own file #13014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13014
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Cancelled Job, 2 Unrelated FailuresAs of commit 8e83ee9 with merge base b054e8d ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77910822 |
This PR needs a
|
metascroy
force-pushed
the
export-D77910822
branch
from
a89ee85 to
6c3f036
Compare
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Jul 31, 2025
Summary: **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77910822 |
larryliu0820
approved these changes
Aug 1, 2025
metascroy
force-pushed
the
export-D77910822
branch
from
6c3f036 to
57477c3
Compare
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 1, 2025
Summary: **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77910822 |
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 1, 2025
Summary: Pull Request resolved: pytorch#13014 **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
metascroy
force-pushed
the
export-D77910822
branch
from
57477c3 to
5f78f9b
Compare
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 1, 2025
Summary: **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
metascroy
force-pushed
the
export-D77910822
branch
from
5f78f9b to
3676a22
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77910822 |
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 1, 2025
Summary: Pull Request resolved: pytorch#13014 **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
metascroy
force-pushed
the
export-D77910822
branch
from
3676a22 to
6b096c1
Compare
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 1, 2025
Summary: **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
metascroy
force-pushed
the
export-D77910822
branch
from
6b096c1 to
5c94aec
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77910822 |
metascroy
force-pushed
the
export-D77910822
branch
from
5c94aec to
cda2b4d
Compare
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 4, 2025
Summary: **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77910822 |
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 4, 2025
Summary: Pull Request resolved: pytorch#13014 **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
metascroy
force-pushed
the
export-D77910822
branch
from
cda2b4d to
503a0e2
Compare
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 4, 2025
Summary: **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
metascroy
force-pushed
the
export-D77910822
branch
from
503a0e2 to
90273f2
Compare
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 4, 2025
Summary: Pull Request resolved: pytorch#13014 **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
metascroy
force-pushed
the
export-D77910822
branch
from
90273f2 to
9b2eba3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77910822 |
metascroy
force-pushed
the
export-D77910822
branch
from
9b2eba3 to
e289c09
Compare
metascroy
pushed a commit
to metascroy/executorch
that referenced
this pull request
Aug 5, 2025
Summary: **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
Summary: Pull Request resolved: pytorch#13014 **Context**: https://fb.workplace.com/groups/pytorch.edge2.team/permalink/1233607881228395/ We want to no longer statically initialize a coreml function on app start during compile time. see CoreML static initializer is called, contributing 293ms+ to app init time: https://pxl.cl/7JmKW **What this diff accomplishes:** Introduces a separate file (namespace) so that we can QE removing this static initalizer during compile time and instead execute its logic when we absolutely need it (app start on startup). We also export the headers as they will be accessed/used in later diffs/files within this stack :) Reviewed By: metascroy Differential Revision: D77910822
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77910822 |
metascroy
force-pushed
the
export-D77910822
branch
from
e289c09 to
8e83ee9
Compare
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Differential Revision: D77910822 Pull Request resolved: pytorch#13014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D77910822