Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jul 30, 2025

Stack from ghstack (oldest at bottom):

Previously we have to provide all essentail infos at the same time to generate etrecord; however if we want to generate it through export flow we can not find a stage that having all essential infos so that we need to have a new way to contruct it on-the-fly.

This diff makes the target happen by adding three functions: add_exported_program, add_edge_dialect_program and add_executorch_program so that whenever we have the required info we can equip it into etrecord.

Also update test case for test coverage.

Differential Revision: D79294945

umbrella issue: #12961

Previously we have to provide all essentail infos at the same time to generate etrecord; however if we want to generate it through export flow we can not find a stage that having all essential infos so that we need to have a new way to contruct it on-the-fly.

This diff makes the target happen by adding three functions: `add_exported_program`, `add_edge_dialect_program` and `add_executorch_program` so that whenever we have the required info we can equip it into etrecord.

Also update test case for test coverage.

Differential Revision: [D79294945](https://our.internmc.facebook.com/intern/diff/D79294945/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13020

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 23e8291 with merge base 8651d31 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2025
Gasoonjia added a commit that referenced this pull request Jul 30, 2025
Previously we have to provide all essentail infos at the same time to generate etrecord; however if we want to generate it through export flow we can not find a stage that having all essential infos so that we need to have a new way to contruct it on-the-fly.

This diff makes the target happen by adding three functions: `add_exported_program`, `add_edge_dialect_program` and `add_executorch_program` so that whenever we have the required info we can equip it into etrecord.

Also update test case for test coverage.

Differential Revision: [D79294945](https://our.internmc.facebook.com/intern/diff/D79294945/)

ghstack-source-id: 299674893
Pull Request resolved: #13020
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79294945

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Previously we have to provide all essentail infos at the same time to generate etrecord; however if we want to generate it through export flow we can not find a stage that having all essential infos so that we need to have a new way to contruct it on-the-fly.

This diff makes the target happen by adding three functions: `add_exported_program`, `add_edge_dialect_program` and `add_executorch_program` so that whenever we have the required info we can equip it into etrecord.

Also update test case for test coverage.

Differential Revision: [D79294945](https://our.internmc.facebook.com/intern/diff/D79294945/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79294945

Previously we have to provide all essentail infos at the same time to generate etrecord; however if we want to generate it through export flow we can not find a stage that having all essential infos so that we need to have a new way to contruct it on-the-fly.

This diff makes the target happen by adding three functions: `add_exported_program`, `add_edge_dialect_program` and `add_executorch_program` so that whenever we have the required info we can equip it into etrecord.

Also update test case for test coverage.

Differential Revision: [D79294945](https://our.internmc.facebook.com/intern/diff/D79294945/)

umbrella issue: #12961

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79294945

Previously we have to provide all essentail infos at the same time to generate etrecord; however if we want to generate it through export flow we can not find a stage that having all essential infos so that we need to have a new way to contruct it on-the-fly.

This diff makes the target happen by adding three functions: `add_exported_program`, `add_edge_dialect_program` and `add_executorch_program` so that whenever we have the required info we can equip it into etrecord.

Also update test case for test coverage.

Differential Revision: [D79294945](https://our.internmc.facebook.com/intern/diff/D79294945/)

umbrella issue: #12961

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79294945

Previously we have to provide all essentail infos at the same time to generate etrecord; however if we want to generate it through export flow we can not find a stage that having all essential infos so that we need to have a new way to contruct it on-the-fly.

This diff makes the target happen by adding three functions: `add_exported_program`, `add_edge_dialect_program` and `add_executorch_program` so that whenever we have the required info we can equip it into etrecord.

Also update test case for test coverage.

Differential Revision: [D79294945](https://our.internmc.facebook.com/intern/diff/D79294945/)

umbrella issue: #12961

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79294945

@facebook-github-bot facebook-github-bot merged commit c143d2b into gh/gasoonjia/31/base Aug 2, 2025
102 of 104 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/gasoonjia/31/head branch August 2, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants