-
Notifications
You must be signed in to change notification settings - Fork 743
Change default minimum_deployment_target to None and support CoreML models with no inputs #13053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13053
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit c5743dc with merge base 5d3550f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@cymbalrush can you have a look? |
This PR needs a
|
|
@cccclai @GregoryComer let me know if you have any concerns with merging. @cymbalrush said the changes look OK on slack |
cccclai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought CoreML doesn't support version <iOS15, is it no longer true? Stamp anyway because Gyan seems good with it
It doesn't support version < iOS15 if you use an mlpackage (which ET uses). This PR is about choosing higher iOS versions than iOS15 if those are required for the model. Currently it's fixed at iOS15 as the default, which could become dated. |
…odels with no inputs (pytorch#13053) This PR changes the default minimum_deployment_target in CoreML from the fixed iOS15 to None. This will automatically select the minimum deployment target required to export the model. A warning occurs after export telling the user the deploymnet target selected, and directing them to specify a specific target if that is what they need. This is more in line with how CoreML standalone works. In addition, this PR allows running CoreML models with no user inputs, which requires CoreML deployment target iOS18 or higher. This addresses: * pytorch#11719 * pytorch#12906
This PR changes the default minimum_deployment_target in CoreML from the fixed iOS15 to None. This will automatically select the minimum deployment target required to export the model.
A warning occurs after export telling the user the deploymnet target selected, and directing them to specify a specific target if that is what they need.
This is more in line with how CoreML standalone works.
In addition, this PR allows running CoreML models with no user inputs, which requires CoreML deployment target iOS18 or higher.
This addresses: