Skip to content

Change default minimum_deployment_target to None and support CoreML models with no inputs #13053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
metascroy merged 1 commit into from
Aug 4, 2025
Merged

Change default minimum_deployment_target to None and support CoreML models with no inputs #13053

metascroy merged 1 commit into from
Aug 4, 2025

Conversation

@metascroy
Copy link
Contributor

@metascroy metascroy commented Aug 1, 2025

This PR changes the default minimum_deployment_target in CoreML from the fixed iOS15 to None. This will automatically select the minimum deployment target required to export the model.

A warning occurs after export telling the user the deploymnet target selected, and directing them to specify a specific target if that is what they need.

This is more in line with how CoreML standalone works.

In addition, this PR allows running CoreML models with no user inputs, which requires CoreML deployment target iOS18 or higher.

This addresses:

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13053

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c5743dc with merge base 5d3550f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2025
@metascroy metascroy requested a review from GregoryComer August 1, 2025 00:16
@metascroy
Copy link
Contributor Author

metascroy commented Aug 1, 2025

@cymbalrush can you have a look?

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@metascroy
Copy link
Contributor Author

metascroy commented Aug 4, 2025

@cccclai @GregoryComer let me know if you have any concerns with merging.

@cymbalrush said the changes look OK on slack

@metascroy metascroy mentioned this pull request Aug 4, 2025
Closed
cccclai
cccclai approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought CoreML doesn't support version <iOS15, is it no longer true? Stamp anyway because Gyan seems good with it

@metascroy
Copy link
Contributor Author

metascroy commented Aug 4, 2025

I thought CoreML doesn't support version <iOS15, is it no longer true? Stamp anyway because Gyan seems good with it

It doesn't support version < iOS15 if you use an mlpackage (which ET uses). This PR is about choosing higher iOS versions than iOS15 if those are required for the model. Currently it's fixed at iOS15 as the default, which could become dated.

@metascroy metascroy merged commit b29a627 into main Aug 4, 2025
231 of 234 checks passed
@metascroy metascroy deleted the support-no-inputs-in-coreml branch August 4, 2025 18:45
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@metascroy @agrima1304
Change default minimum_deployment_target to None and support CoreML m…
6488a89 
…odels with no inputs (pytorch#13053)

This PR changes the default minimum_deployment_target in CoreML from the
fixed iOS15 to None. This will automatically select the minimum
deployment target required to export the model.

A warning occurs after export telling the user the deploymnet target
selected, and directing them to specify a specific target if that is
what they need.

This is more in line with how CoreML standalone works.

In addition, this PR allows running CoreML models with no user inputs,
which requires CoreML deployment target iOS18 or higher.

This addresses:
* pytorch#11719
* pytorch#12906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@metascroy @cccclai