Skip to content

Conversation

@wwwind
Copy link
Collaborator

@wwwind wwwind commented Aug 1, 2025

Fix error with "is_U55_subset" by changing TOSAQuantizer to accept compiled spec

Change-Id: I164d68190e6fb9edd2efb9c8bd2da8c1bfc4e406
Signed-off-by: Elena Zhelezina [email protected]

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Fix error with "is_U55_subset" by changing TOSAQuantizer to
accept compiled spec

Signed-off-by: Elena Zhelezina <[email protected]>
Change-Id: I164d68190e6fb9edd2efb9c8bd2da8c1bfc4e406
@wwwind wwwind requested a review from digantdesai as a code owner August 1, 2025 11:14
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13065

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Cancelled Job, 1 Unrelated Failure

As of commit 57e5336 with merge base 90ff059 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2025
@wwwind wwwind requested a review from zingo August 1, 2025 11:14
@wwwind wwwind added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels Aug 1, 2025
@zingo
Copy link
Collaborator

zingo commented Aug 6, 2025

fails are unrerlated

@zingo zingo merged commit e55bf54 into pytorch:main Aug 6, 2025
226 of 230 checks passed

def __init__(self, tosa_spec: TosaSpecification) -> None:
def __init__(
self, compile_spec_or_tosa_spec: Union[TosaSpecification, List[CompileSpec]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: do you want to split into two constructors, instead of overloading..

def __init__(self, tosa_spec):
[...]

and

@classmethod
def from_compilespec(self, compilespec):
[...]

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
…fix for bug with is_U55_subset (pytorch#13065)

Fix error with "is_U55_subset" by changing TOSAQuantizer to accept
compiled spec

Signed-off-by: Elena Zhelezina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants