Skip to content

Decouple LlavaRunner from multimodal runner #13067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Aug 1, 2025
Merged

Decouple LlavaRunner from multimodal runner #13067

facebook-github-bot merged 1 commit into from
Aug 1, 2025

Conversation

@larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Aug 1, 2025

Summary: Make sure upcoming changes to MultimodalRunner class doesn't break existing LlavaRunner. Eventually LlavaRunner will be deprecated and we will use MultimodalRunner for Llava demo and app integration.

Reviewed By: jackzhxng

Differential Revision: D78997241

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13067

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Pending

As of commit b46b6fb with merge base d80dfa3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D78997241

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

facebook-github-bot pushed a commit that referenced this pull request Aug 1, 2025
@larryliu0820 @facebook-github-bot
Decouple LlavaRunner from multimodal runner (#13067)
27df879 
Summary:

Make sure upcoming changes to `MultimodalRunner` class doesn't break existing `LlavaRunner`. Eventually `LlavaRunner` will be deprecated and we will use `MultimodalRunner` for Llava demo and app integration.

Reviewed By: jackzhxng

Differential Revision: D78997241
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D78997241

facebook-github-bot pushed a commit that referenced this pull request Aug 1, 2025
@larryliu0820 @facebook-github-bot
Decouple LlavaRunner from multimodal runner (#13067)
152be1b 
Summary:

Make sure upcoming changes to `MultimodalRunner` class doesn't break existing `LlavaRunner`. Eventually `LlavaRunner` will be deprecated and we will use `MultimodalRunner` for Llava demo and app integration.

Reviewed By: jackzhxng

Differential Revision: D78997241
larryliu0820 added a commit that referenced this pull request Aug 1, 2025
@larryliu0820 @facebook-github-bot
Decouple LlavaRunner from multimodal runner (#13067)
3ad63e0 
Summary:

Make sure upcoming changes to `MultimodalRunner` class doesn't break existing `LlavaRunner`. Eventually `LlavaRunner` will be deprecated and we will use `MultimodalRunner` for Llava demo and app integration.

Reviewed By: jackzhxng

Differential Revision: D78997241
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D78997241

@larryliu0820 @facebook-github-bot
Decouple LlavaRunner from multimodal runner (#13067)
b46b6fb 
Summary:
Pull Request resolved: #13067

Make sure upcoming changes to `MultimodalRunner` class doesn't break existing `LlavaRunner`. Eventually `LlavaRunner` will be deprecated and we will use `MultimodalRunner` for Llava demo and app integration.

Reviewed By: jackzhxng

Differential Revision: D78997241
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D78997241

@facebook-github-bot facebook-github-bot merged commit 48e4822 into main Aug 1, 2025
102 of 105 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D78997241 branch August 1, 2025 21:14
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@larryliu0820 @agrima1304
Decouple LlavaRunner from multimodal runner
8148693 
Differential Revision: D78997241

Pull Request resolved: pytorch#13067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackzhxng jackzhxng jackzhxng approved these changes

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@larryliu0820 @facebook-github-bot @jackzhxng