Skip to content

Add ISSRuntimeFailure to improve exception handling #13069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Aug 4, 2025
Merged

Add ISSRuntimeFailure to improve exception handling #13069

facebook-github-bot merged 1 commit into from
Aug 4, 2025

Conversation

@mcremon-meta
Copy link
Contributor

@mcremon-meta mcremon-meta commented Aug 1, 2025

Summary: As titled.

Differential Revision: D79265023

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 1, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13069

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending, 2 Unrelated Failures

As of commit c552154 with merge base cf2f170 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D79265023

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

mcremon-meta added a commit that referenced this pull request Aug 1, 2025
@mcremon-meta @facebook-github-bot
Add ETDump failure to improve exception handling (#13069)
eb194d7 
Summary:

As titled.

Differential Revision: D79265023
mcremon-meta added a commit that referenced this pull request Aug 1, 2025
@mcremon-meta @facebook-github-bot
Add ETDump failure to improve exception handling (#13069)
10131f4 
Summary:
Pull Request resolved: #13069

As titled.

Differential Revision: D79265023
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D79265023

@mcremon-meta mcremon-meta changed the title Add ETDump failure to improve exception handling Add ISSRuntimeFailure to improve exception handling Aug 1, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D79265023

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D79265023

facebook-github-bot pushed a commit that referenced this pull request Aug 1, 2025
@mcremon-meta @facebook-github-bot
Add ETDump failure to improve exception handling (#13069)
9879574 
Summary:

As titled.

Reviewed By: hsharma35

Differential Revision: D79265023
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D79265023

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 1, 2025

This pull request was exported from Phabricator. Differential Revision: D79265023

mcremon-meta added a commit that referenced this pull request Aug 1, 2025
@mcremon-meta @facebook-github-bot
Add ETDump failure to improve exception handling (#13069)
e73a01a 
Summary:
Pull Request resolved: #13069

As titled.

Reviewed By: hsharma35

Differential Revision: D79265023
mcremon-meta added a commit that referenced this pull request Aug 4, 2025
@mcremon-meta @facebook-github-bot
Add ISSRuntimeFailure to improve exception handling (#13069)
53b7be7 
Summary:

As titled.

Reviewed By: hsharma35

Differential Revision: D79265023
@mcremon-meta @facebook-github-bot
Add ISSRuntimeFailure to improve exception handling (#13069)
c552154 
Summary:
Pull Request resolved: #13069

As titled.

Reviewed By: hsharma35

Differential Revision: D79265023
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 4, 2025

This pull request was exported from Phabricator. Differential Revision: D79265023

@facebook-github-bot facebook-github-bot merged commit ec35f56 into main Aug 4, 2025
99 of 105 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D79265023 branch August 4, 2025 21:07
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@mcremon-meta @agrima1304
Add ISSRuntimeFailure to improve exception handling
a7546c7 
Differential Revision: D79265023

Pull Request resolved: pytorch#13069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsharma35 hsharma35 hsharma35 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcremon-meta @facebook-github-bot @hsharma35