Skip to content

Improve softmax perf when transpose is not needed #13081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Aug 19, 2025
Merged

Improve softmax perf when transpose is not needed #13081

facebook-github-bot merged 1 commit into from
Aug 19, 2025

Conversation

@mcremon-meta
Copy link
Contributor

@mcremon-meta mcremon-meta commented Aug 3, 2025

Differential Revision: D79514231

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13081

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ceb8d36 with merge base fe84495 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 3, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 3, 2025

This pull request was exported from Phabricator. Differential Revision: D79514231

@github-actions
Copy link

github-actions bot commented Aug 3, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 4, 2025

This pull request was exported from Phabricator. Differential Revision: D79514231

mcremon-meta added a commit that referenced this pull request Aug 18, 2025
@mcremon-meta @facebook-github-bot
Improve softmax perf when transpose is not needed (#13081)
1ab590c 
Summary:

When the supplied dimension is the last dim of the tensor, we don't need to permute anything and can call the nnlib kernel directly.

Differential Revision: D79514231
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 18, 2025

This pull request was exported from Phabricator. Differential Revision: D79514231

mcremon-meta added a commit that referenced this pull request Aug 18, 2025
@mcremon-meta @facebook-github-bot
Improve softmax perf when transpose is not needed (#13081)
3e0bf0c 
Summary:
Pull Request resolved: #13081

When the supplied dimension is the last dim of the tensor, we don't need to permute anything and can call the nnlib kernel directly.

Differential Revision: D79514231
mcremon-meta added a commit that referenced this pull request Aug 18, 2025
@mcremon-meta @facebook-github-bot
Improve softmax perf when transpose is not needed (#13081)
c39cede 
Summary:

When the supplied dimension is the last dim of the tensor, we don't need to permute anything and can call the nnlib kernel directly.

Differential Revision: D79514231
@mcremon-meta @facebook-github-bot
Improve softmax perf when transpose is not needed (#13081)
ceb8d36 
Summary:
Pull Request resolved: #13081

When the supplied dimension is the last dim of the tensor, we don't need to permute anything and can call the nnlib kernel directly.

Differential Revision: D79514231
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 18, 2025

This pull request was exported from Phabricator. Differential Revision: D79514231

@facebook-github-bot facebook-github-bot merged commit 7c8f637 into main Aug 19, 2025
103 of 106 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D79514231 branch August 19, 2025 22:06
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@mcremon-meta @agrima1304
Improve softmax perf when transpose is not needed
4174b03 
Differential Revision: D79514231

Pull Request resolved: pytorch#13081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zonglinpeng zonglinpeng zonglinpeng approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcremon-meta @facebook-github-bot @zonglinpeng