Skip to content

Conversation

@metascroy
Copy link
Contributor

@metascroy metascroy commented Aug 4, 2025

This PR

  • Renames EXECUTORCH_BUILD_TORCHAO to EXECUTORCH_BUILD_KERNELS_TORCHAO to be more in line with other kernel options (e.g., EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
  • Fixes torchao lowbit kernel dependencies in xcframeworks
  • Adds torchao lowbit kernels to the swift package

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13107

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 8653c0f with merge base 010b800 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2025
@metascroy metascroy added ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 4, 2025
@github-actions
Copy link

github-actions bot commented Aug 4, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2025
@metascroy metascroy requested a review from shoumikhin August 5, 2025 01:03
@metascroy metascroy marked this pull request as ready for review August 5, 2025 01:03
@metascroy
Copy link
Contributor Author

@shoumikhin can I get review on the swift changes here + xcframework changes?

@metascroy metascroy merged commit ea4a7fa into main Aug 13, 2025
354 of 363 checks passed
@metascroy metascroy deleted the fix-torchao-deps branch August 13, 2025 16:39
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
This PR

* Renames EXECUTORCH_BUILD_TORCHAO to EXECUTORCH_BUILD_KERNELS_TORCHAO
to be more in line with other kernel options (e.g.,
EXECUTORCH_BUILD_KERNELS_OPTIMIZED)
* Fixes torchao lowbit kernel dependencies in xcframeworks
* Adds torchao lowbit kernels to the swift package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants