NXP backend: Return number of Neutron nodes in exception #13126
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13126
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 3c30c9c with merge base 72580d2 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@pytorchbot label "release notes: nxp" |
pytorch-bot
bot
added
the
release notes: nxp
StrycekSimon
force-pushed
the
upstream/main-nxp/EIEX-459-upstream-neutron-node-extraction-error-output-enhancement
branch
from
7355979 to
3c30c9c
Compare
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
| raise RuntimeError( | ||
| "Model converted with neutron-converter has `0` operators instead of `1`." | ||
| "Model converted with neutron-converter has `0` operators instead of `1`.", | ||
| sub_graph.OperatorsLength(), |
There was a problem hiding this comment.
you've already hardcoded to zero, you can remove this
There was a problem hiding this comment.
Don't know how I missed this one...
Edit: Apparently, it is there just to be consistent with the other errors.
There was a problem hiding this comment.
@JakeStevens , maybe I missunderstood your point, but the first check verifies there is only one subgraph in the Neutron IR flatbuffer (subgraph is like the pytorch's method). And this check verifies now many nodes are in the first subgraph.
There was a problem hiding this comment.
@JakeStevens , maybe I missunderstood your point, but the first check verifies there is only one
subgraphin the Neutron IR flatbuffer (subgraph is like the pytorch's method). And this check verifies now many nodes are in the first subgraph.
I just mean that sub_graph.OperatorsLength() does not offer any more information in this case for the RuntimeError, since sub_graph.OperatorsLength == 0 and that is explicitly written out in the string already
robert-kalmar
changed the title
robert-kalmar
deleted the
upstream/main-nxp/EIEX-459-upstream-neutron-node-extraction-error-output-enhancement
branch
### Summary Return number of Neutron nodes in exception. Co-authored-by: Roman Janik <[email protected]>
5 participants
Summary
Adds return number of Neutron nodes in exception.
cc @robert-kalmar @roman-janik-nxp