Extend EdgeProgramManager::transform() method declaration with PassManager as a "passes" param variant. #13140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from eigen-k:export-D79292048

Aug 7, 2025

Contributor

eigen-k commented Aug 5, 2025

Summary: There is a user request to pass a custom PassManager to the EdgeProgramManager::transform(). This diff extends method API appropriately.

Differential Revision: D79292048

eigen-k requested review from JacobSzwejbka and larryliu0820 as code owners

August 5, 2025 21:26

pytorch-bot bot commented Aug 5, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13140

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit 15c6cb4 with merge base b114f9c ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold
pull / test-moshi-linux / linux-job (gh)
RuntimeError: Command docker exec -t fa470b63ea0046e01ed5501be8bcefac88fadfc20208f90ba8a2d0a24e8d2acb /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-openvino-linux / linux-job (gh) (trunk failure)
AttributeError: '_OpNamespace' 'quantized_decomposed' object has no attribute 'convert_element_type'
pull / unittest / linux / linux-job (gh) (trunk failure)
/pytorch/executorch/backends/vulkan/runtime/graph/ops/impl/Reduce.cpp:41:26: error: 'get_tensor' is a protected member of 'vkcompute::ComputeGraph'
pull / unittest-editable / linux / linux-job (gh) (trunk failure)
/pytorch/executorch/backends/vulkan/runtime/graph/ops/impl/Reduce.cpp:41:26: error: 'get_tensor' is a protected member of 'vkcompute::ComputeGraph'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D79292048

facebook-github-bot added the fb-exported label

eigen-k added a commit to eigen-k/executorch that referenced this pull request


          Extend tranform() method params with PassManager. (pytorch#13140)

c390704

Summary:

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Differential Revision: D79292048

eigen-k force-pushed the export-D79292048 branch from 0f18884 to c390704 Compare

August 5, 2025 21:29

Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D79292048

eigen-k added a commit to eigen-k/executorch that referenced this pull request


          Extend tranform() method params with PassManager. (pytorch#13140)

0c18261

Summary:
Pull Request resolved: pytorch#13140

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Differential Revision: D79292048

eigen-k force-pushed the export-D79292048 branch 2 times, most recently from 0c18261 to d095216 Compare

August 6, 2025 18:36

eigen-k added a commit to eigen-k/executorch that referenced this pull request


          Extend tranform() method params with PassManager. (pytorch#13140)

d095216

Summary:

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Differential Revision: D79292048

Contributor

facebook-github-bot commented Aug 6, 2025

This pull request was exported from Phabricator. Differential Revision: D79292048

eigen-k added the release notes: none label

larryliu0820 approved these changes

View reviewed changes

eigen-k added a commit to eigen-k/executorch that referenced this pull request


          Extend tranform() method params with PassManager. (pytorch#13140)

a57f65c

Summary:

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Reviewed By: larryliu0820

Differential Revision: D79292048

eigen-k force-pushed the export-D79292048 branch from d095216 to a57f65c Compare

August 6, 2025 18:52

Contributor

facebook-github-bot commented Aug 6, 2025

This pull request was exported from Phabricator. Differential Revision: D79292048

eigen-k added a commit to eigen-k/executorch that referenced this pull request


          Extend tranform() method params with PassManager. (pytorch#13140)

ab56fd0

Summary:
Pull Request resolved: pytorch#13140

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Reviewed By: larryliu0820

Differential Revision: D79292048

eigen-k force-pushed the export-D79292048 branch from a57f65c to ab56fd0 Compare

August 6, 2025 18:57

eigen-k added a commit to eigen-k/executorch that referenced this pull request


          Extend tranform() method params with PassManager. (pytorch#13140)

81780d2

Summary:

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Reviewed By: larryliu0820

Differential Revision: D79292048

eigen-k force-pushed the export-D79292048 branch from ab56fd0 to 81780d2 Compare

August 6, 2025 21:06

Contributor

facebook-github-bot commented Aug 6, 2025

This pull request was exported from Phabricator. Differential Revision: D79292048

eigen-k added a commit to eigen-k/executorch that referenced this pull request


          Extend EdgeProgramManager::transform() method declaration with PassMa…

88d5930

…nager as a "passes" param variant. (pytorch#13140)

Summary:

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Reviewed By: larryliu0820

Differential Revision: D79292048

eigen-k force-pushed the export-D79292048 branch from 81780d2 to 88d5930 Compare

August 6, 2025 23:23

eigen-k added a commit to eigen-k/executorch that referenced this pull request


          Extend tranform() method params with PassManager. (pytorch#13140)

Summary:

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Reviewed By: larryliu0820

Differential Revision: D79292048

eigen-k force-pushed the export-D79292048 branch from 88d5930 to 9337410 Compare

August 6, 2025 23:23

Contributor

facebook-github-bot commented Aug 6, 2025

This pull request was exported from Phabricator. Differential Revision: D79292048

1 similar comment

Contributor

facebook-github-bot commented Aug 6, 2025

This pull request was exported from Phabricator. Differential Revision: D79292048

eigen-k added a commit to eigen-k/executorch that referenced this pull request


          Extend EdgeProgramManager::transform() method declaration with PassMa…

8d88a47

…nager as a "passes" param variant. (pytorch#13140)

Summary:
Pull Request resolved: pytorch#13140

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Reviewed By: larryliu0820

Differential Revision: D79292048

eigen-k force-pushed the export-D79292048 branch from 9337410 to 8d88a47 Compare

August 6, 2025 23:26


          Extend EdgeProgramManager::transform() method declaration with PassMa…

15c6cb4

…nager as a "passes" param variant. (pytorch#13140)

Summary:

There is a user request to pass a custom PassManager to the  EdgeProgramManager::transform(). This diff extends method API appropriately.

Reviewed By: larryliu0820

Differential Revision: D79292048

eigen-k force-pushed the export-D79292048 branch from 8d88a47 to 15c6cb4 Compare

August 7, 2025 16:18

Contributor

facebook-github-bot commented Aug 7, 2025

This pull request was exported from Phabricator. Differential Revision: D79292048

eigen-k changed the title ~~Extend tranform() method params with PassManager.~~ Extend EdgeProgramManager::transform() method declaration with PassManager as a "passes" param variant.

facebook-github-bot merged commit afdbb85 into pytorch:main

98 of 104 checks passed

agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request


          Extend EdgeProgramManager::transform() method declaration with PassMa…

0d26250

…nager as a "passes" param variant.

Differential Revision: D79292048

Pull Request resolved: pytorch#13140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported release notes: none