make ExecuTorch program always has valid debug handle map and delegate map #13149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13149
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 5a3e4c1 with merge base 134becb ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79706058 |
This PR needs a
|
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Aug 6, 2025
…e map (pytorch#13149) Summary: Currently ExecuTorchProgram's debug handle map and delegate map will be empty if we didn't call its _get_emitter_output function directly or indrectly before. This behavior doesn't make sense because: a. the empty result can not reflect the executorch program's state b. not in line with ExecuTorchProgramManager behavior c. other attributes, like self.buffer and self.program, do not have such behavir and can always return valid result. This PR makes them always has valid value.. Differential Revision: D79706058
Gasoonjia
force-pushed
the
export-D79706058
branch
from
3c1a450 to
30f7c34
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79706058 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Aug 6, 2025
…e map (pytorch#13149) Summary: Pull Request resolved: pytorch#13149 Currently ExecuTorchProgram's debug handle map and delegate map will be empty if we didn't call its _get_emitter_output function directly or indrectly before. This behavior doesn't make sense because: a. the empty result can not reflect the executorch program's state b. not in line with ExecuTorchProgramManager behavior c. other attributes, like self.buffer and self.program, do not have such behavir and can always return valid result. This PR makes them always has valid value.. Differential Revision: D79706058
Gasoonjia
force-pushed
the
export-D79706058
branch
from
30f7c34 to
428f603
Compare
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Aug 6, 2025
…e map (pytorch#13149) Summary: Currently ExecuTorchProgram's debug handle map and delegate map will be empty if we didn't call its _get_emitter_output function directly or indrectly before. This behavior doesn't make sense because: a. the empty result can not reflect the executorch program's state b. not in line with ExecuTorchProgramManager behavior c. other attributes, like self.buffer and self.program, do not have such behavir and can always return valid result. This PR makes them always has valid value.. Differential Revision: D79706058
Gasoonjia
force-pushed
the
export-D79706058
branch
from
428f603 to
afbe13b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79706058 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Aug 6, 2025
…e map (pytorch#13149) Summary: Currently ExecuTorchProgram's debug handle map and delegate map will be empty if we didn't call its _get_emitter_output function directly or indrectly before. This behavior doesn't make sense because: a. the empty result can not reflect the executorch program's state b. not in line with ExecuTorchProgramManager behavior c. other attributes, like self.buffer and self.program, do not have such behavir and can always return valid result. This PR makes them always has valid value.. Differential Revision: D79706058
Gasoonjia
force-pushed
the
export-D79706058
branch
from
afbe13b to
7d5ece5
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79706058 |
JacobSzwejbka
approved these changes
Aug 6, 2025
…e map (pytorch#13149) Summary: Currently ExecuTorchProgram's debug handle map and delegate map will be empty if we didn't call its _get_emitter_output function directly or indrectly before. This behavior doesn't make sense because: a. the empty result can not reflect the executorch program's state b. not in line with ExecuTorchProgramManager behavior c. other attributes, like self.buffer and self.program, do not have such behavir and can always return valid result. This PR makes them always has valid value.. Reviewed By: JacobSzwejbka Differential Revision: D79706058
Gasoonjia
force-pushed
the
export-D79706058
branch
from
7d5ece5 to
5a3e4c1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79706058 |
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…e map Differential Revision: D79706058 Pull Request resolved: pytorch#13149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently ExecuTorchProgram's debug handle map and delegate map will be empty if we didn't call its _get_emitter_output function directly or indrectly before. This behavior doesn't make sense because:
a. the empty result can not reflect the executorch program's state
b. not in line with ExecuTorchProgramManager behavior
c. other attributes, like self.buffer and self.program, do not have such behavir and can always return valid result.
This PR makes them always has valid value..
Differential Revision: D79706058