[ET-VK] Fix Build Errors in Vulkan Backend #13170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13170
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit 8dc3bcb with merge base 112a09f ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "release notes: vulkan" |
pytorch-bot
bot
added
the
release notes: vulkan
Collaborator
Author
|
@pytorchbot label "release notes: vulkan" |
SS-JIA
approved these changes
Aug 7, 2025
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
This change fixes build issues that arose from the addition of 2D reduction to the Vulkan backend: pytorch@112a09f ```get_tensor()``` was moved to be a protected member of ComputeGraph a few minutes before the above commit got merged. This change also slightly modifies op_registry.py to have a more conservative approach of allowing 2D reduction to be delegated. cc @SS-JIA @manuelcandales @cbilgin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes build issues that arose from the addition of 2D reduction to the Vulkan backend:
112a09f
get_tensor()was moved to be a protected member of ComputeGraph a few minutes before the above commit got merged.This change also slightly modifies op_registry.py to have a more conservative approach of allowing 2D reduction to be delegated.
cc @SS-JIA @manuelcandales @cbilgin