Arm backend: Remove submodule serialization_lib #13178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the git submodule serialization_lib since its pointing to an old 0.80 tag and is not used by the arm backend. Instead this library is now cloned part of the tosa-reference-module when needed. Change-Id: I34a3707b35cab6413e8aa5365fc41d404b4eb9fa Signed-off-by: [email protected]
perheld
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13178
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Pending, 4 Unrelated FailuresAs of commit df250e5 with merge base 264a91b ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
robell
approved these changes
Aug 7, 2025
Collaborator
|
Unit test fails unrelated |
Collaborator
|
Ooops, was maybe a bit fast on this PR @digantdesai maybe you wanted to review/merge this, feel free to revert if it cause problems and we can figure it out. EDIT: I revert it so we can take this change slower as it deserves |
Collaborator
|
I revert it so we can take this change slower as it deserves, sorry for the extra work |
zingo
added a commit
that referenced
this pull request
Aug 7, 2025
Contributor
|
If I were to guess, this should be OK. I can pull the next, new PR internally and make sure. Thanks @zingo. |
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Remove the git submodule serialization_lib since its pointing to an old 0.80 tag and is not used by the arm backend. Instead this library is now cloned part of the tosa-reference-module when needed. Signed-off-by: [email protected]
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the git submodule serialization_lib since its pointing to an old 0.80 tag and is not used by the arm backend.
Instead this library is now cloned part of the tosa-reference-module when needed.
Change-Id: I34a3707b35cab6413e8aa5365fc41d404b4eb9fa
Signed-off-by: [email protected]
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218