Skip to content

Conversation

@winskuo-quic
Copy link
Collaborator

@winskuo-quic winskuo-quic commented Aug 8, 2025

Summary

  • This PR will fix BC CI to use the right tokenizer, initially 260k accidently use 110m tokenizer during runtime.
  • Fix custom annotation where conv has bias node.

Test plan

@winskuo-quic winskuo-quic requested a review from cccclai as a code owner August 8, 2025 02:32
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13212

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit c2e3ba5 with merge base be221c6 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2025
@github-actions
Copy link

github-actions bot commented Aug 8, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic
Copy link
Collaborator Author

winskuo-quic commented Aug 8, 2025

Hi @cccclai,

  1. We notice currently there are a couple of Qualcomm PRs failing in BC CI. This fix is cherry-picked from Qualcomm AI Engine Direct - Static Decoder Runner Support 16bit KV IO #13127. Please take your time reviewing Qualcomm AI Engine Direct - Static Decoder Runner Support 16bit KV IO #13127. However, we might need this PR go in first so we can unblock other PRs that is also failing this CI. Thanks!
  2. Recently, conv_former CI is added. I made a small change to the CI since we won't be able to have access to dataset on CI machines. I have aligned the behavior of conv_former with other models, which is to use dummy input. Please have a look. Thanks

Hi @rohansjoshi,
This PR should fix the custom annotation issue you encountered when conv has bias node. Please have a look. Thanks

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/custom_annotation_fix branch from 91da1dd to baa8c8f Compare August 8, 2025 03:13
@cccclai cccclai merged commit 41d05fe into pytorch:main Aug 8, 2025
215 of 218 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
…rch#13212)

### Summary

- This PR will fix BC CI to use the right tokenizer, initially 260k
accidently use 110m tokenizer during runtime.
- Fix custom annotation where conv has bias node.

### Test plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants