Skip to content

Added ETDump to Wasm #13304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Conarnar merged 3 commits into from
Aug 12, 2025
Merged

Added ETDump to Wasm #13304

Conarnar merged 3 commits into from
Aug 12, 2025

Conversation

@Conarnar
Copy link
Contributor

@Conarnar Conarnar commented Aug 11, 2025

Summary

Turning on the EXECUTORCH_ENABLE_EVENT_TRACER option will enable event tracing in the Wasm module API. The results can be obtained with the etdump() method.

Test plan

Added two tests depending on whether EXECUTORCH_ENABLE_EVENT_TRACER is turned on or not. Added the --enable-etdump option to scripts/build_wasm_tests.sh which turns on the above option.

Added configurations to the unittest-wasm-bindings CI test to run with and without --enable-etdump.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13304

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ebeb7de with merge base 8e73c09 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 11, 2025
@github-actions
Copy link

github-actions bot commented Aug 11, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Conarnar Conarnar marked this pull request as draft August 12, 2025 00:13
@Conarnar Conarnar marked this pull request as ready for review August 12, 2025 00:31
lucylq
lucylq reviewed Aug 12, 2025
View reviewed changes
scripts/build_wasm_tests.sh
if [ "$arg" == "--enable-etdump" ]; then
ETDUMP_OPTS="-DEXECUTORCH_ENABLE_EVENT_TRACER=ON \
-DEXECUTORCH_BUILD_DEVTOOLS=ON \
-DFLATCC_ALLOW_WERROR=OFF"
Copy link
Contributor

@lucylq lucylq Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here on why this flag is required?

lucylq
lucylq approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also cc @Gasoonjia on devtools

@Gasoonjia
Copy link
Contributor

Gasoonjia commented Aug 12, 2025

LGTM.
Is there any buck target we need to update?

@lucylq
Copy link
Contributor

lucylq commented Aug 12, 2025

LGTM. Is there any buck target we need to update?

I think all of the wasm work has been in OSS, so there aren't buck targets for it and it won't break CI.

Conan and I had a quick look, and there is emscripten internally that we could use from fbsource/third-party if we wanted to buckify things cc @JacobSzwejbka

@Conarnar Conarnar merged commit a4b59cc into pytorch:main Aug 12, 2025
102 of 103 checks passed
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@Conarnar @agrima1304
Added ETDump to Wasm (pytorch#13304)
fbba9c2 
### Summary
Turning on the `EXECUTORCH_ENABLE_EVENT_TRACER` option will enable event
tracing in the Wasm module API. The results can be obtained with the
`etdump()` method.

### Test plan
Added two tests depending on whether `EXECUTORCH_ENABLE_EVENT_TRACER` is
turned on or not. Added the `--enable-etdump` option to
`scripts/build_wasm_tests.sh` which turns on the above option.

Added configurations to the `unittest-wasm-bindings` CI test to run with
and without `--enable-etdump`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucylq lucylq lucylq approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@GregoryComer GregoryComer Awaiting requested review from GregoryComer GregoryComer is a code owner

@swolchok swolchok Awaiting requested review from swolchok

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Conarnar @Gasoonjia @lucylq