Skip to content

Link Vulkan backend with pybinding lib when built #13309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: gh/GregoryComer/120/head
Choose a base branch
from

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 12, 2025

Add the Vulkan backend as a dependency to the pybinding build, when built. I've validated that I can run a simple Vulkan model on pybindings with this change on Mac (via MoltenVK).

Note that I'm not updating the preset to always build Vulkan yet. It requires additional dependencies and thus needs more discussion. I'm not sure if we can auto-install everything that we need. I'll get @SS-JIA's opinion on this. Also, once executorch::backends target is installable, I'll switch pybindings to use that target.

Tracking task: #12895.

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Aug 12, 2025
Copy link

pytorch-bot bot commented Aug 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13309

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 94d89c4 with merge base 3a02146 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
@GregoryComer GregoryComer changed the base branch from gh/GregoryComer/120/head to gh/GregoryComer/119/head August 12, 2025 05:24
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer GregoryComer changed the base branch from gh/GregoryComer/119/head to gh/GregoryComer/120/head August 12, 2025 05:59
@GregoryComer GregoryComer marked this pull request as ready for review August 12, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant