Skip to content

Link Vulkan backend with pybinding lib when built #13309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: gh/GregoryComer/120/head
Choose a base branch
from
Open

Link Vulkan backend with pybinding lib when built #13309

wants to merge 9 commits into from
+4 −0

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 12, 2025 •
edited
Loading

Add the Vulkan backend as a dependency to the pybinding build, when built. I've validated that I can run a simple Vulkan model on pybindings with this change on Mac (via MoltenVK).

Note that I'm not updating the preset to always build Vulkan yet. It requires additional dependencies and thus needs more discussion. I'm not sure if we can auto-install everything that we need. I'll get @SS-JIA's opinion on this. Also, once executorch::backends target is installable, I'll switch pybindings to use that target.

Tracking task: #12895.

@GregoryComer
Update
2c4488f 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Aug 12, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Aug 12, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13309

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 4 Unrelated Failures

As of commit 778f7cd with merge base c5db75b (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2025
GregoryComer added a commit that referenced this pull request Aug 12, 2025
@GregoryComer
Link Vulkan backend with pybinding lib when built
21c3b83 
ghstack-source-id: 9773513
ghstack-comment-id: 3177632519
Pull-Request: #13309
This was referenced Aug 12, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Open
Open
This was referenced Aug 12, 2025
Open
Open
@GregoryComer
Update
fc1c2a7 
[ghstack-poisoned]
@GregoryComer GregoryComer changed the base branch from gh/GregoryComer/120/head to gh/GregoryComer/119/head August 12, 2025 05:24
@GregoryComer
Update
605a0ad 
[ghstack-poisoned]
@GregoryComer
Update
94d89c4 
[ghstack-poisoned]
@GregoryComer GregoryComer changed the base branch from gh/GregoryComer/119/head to gh/GregoryComer/120/head August 12, 2025 05:59
@GregoryComer GregoryComer mentioned this pull request Aug 12, 2025
Open
@GregoryComer GregoryComer marked this pull request as ready for review August 12, 2025 06:12
digantdesai
digantdesai approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's discuss this. @GregoryComer do you mean other deps like - .ci/scripts/setup-vulkan-linux-deps.sh ?

Also FYI Stephen was saying SwiftShader may not have all the Vulkan extensions we need so that might make testing a bit more complicated.

@GregoryComer
Update
dd30127 
[ghstack-poisoned]
@GregoryComer
Update
49944fa 
[ghstack-poisoned]
@GregoryComer
Update
f4df9c9 
[ghstack-poisoned]
@GregoryComer
Update
51c392a 
[ghstack-poisoned]
@GregoryComer
Update
778f7cd 
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GregoryComer @digantdesai