-
Notifications
You must be signed in to change notification settings - Fork 646
[Backend Tester] Reduce log verbosity / spam #13312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 170 commits
Commits
Show all changes
181 commits
Select commit
Hold shift + click to select a range
f120e70
Update
GregoryComer 0fb85e6
Update
GregoryComer 4d8d844
Update
GregoryComer dc12b40
Update
GregoryComer ead0616
Update
GregoryComer 0f13676
Update
GregoryComer b0b01f2
Update
GregoryComer 8b9c9ef
Update
GregoryComer 06bf03a
Update
GregoryComer 2f8f49b
Update
GregoryComer 8ca7766
Update
GregoryComer bffb95f
Update
GregoryComer d21492b
Update
GregoryComer e2c4ea5
Update
GregoryComer 8230848
Update
GregoryComer 2a1f564
Update
GregoryComer b35e7b1
Update
GregoryComer 5c4c6ce
Update
GregoryComer 9397803
Update
GregoryComer 9dfeb5a
Update
GregoryComer ff5c4a5
Update
GregoryComer 42a5de5
Update
GregoryComer 402d8f5
Update
GregoryComer 34d3ab3
Update
GregoryComer 1105e04
Update
GregoryComer 482bd21
Update
GregoryComer ea548b7
Update
GregoryComer 4108f54
Update
GregoryComer 7ef236b
Update
GregoryComer 4a58c9d
Update
GregoryComer 3b866b4
Update
GregoryComer 5ba25cb
Update
GregoryComer 19760fc
Update
GregoryComer 81dfb07
Update
GregoryComer 4d50265
Update
GregoryComer 5f66043
Update
GregoryComer 24e919d
Update
GregoryComer 523cc20
Update
GregoryComer 74c95fe
Update
GregoryComer 5d437b1
Update
GregoryComer 89757ce
Update
GregoryComer 423f79a
Update
GregoryComer 69f7f9c
Update
GregoryComer c0f6224
Update
GregoryComer e2ea2a3
Update
GregoryComer 7a2fab5
Update
GregoryComer 033c231
Update
GregoryComer a9ed762
Update
GregoryComer 64b174a
Update
GregoryComer 3976629
Update
GregoryComer 27cd171
Update
GregoryComer 7bdd3e5
Update
GregoryComer b1254cd
Update
GregoryComer f2e2289
Update
GregoryComer cdd15c1
Update
GregoryComer e2df06e
Update
GregoryComer 4461bd8
Update
GregoryComer 7e97fd0
Update
GregoryComer bcb697c
Update
GregoryComer 11a5a02
Update
GregoryComer 244b146
Update
GregoryComer de21ac2
Update
GregoryComer fd26fc7
Update
GregoryComer 4ae840d
Update
GregoryComer 710ea49
Update
GregoryComer 32f54b0
Update
GregoryComer a27d18c
Update
GregoryComer 2eb59fc
Update
GregoryComer 5cc4941
Update
GregoryComer ef7af5c
Update
GregoryComer 18e89c1
Update
GregoryComer 4719c90
Update
GregoryComer dd09555
Update
GregoryComer f1db3a0
Update
GregoryComer e0700b2
Update
GregoryComer f260b50
Update
GregoryComer d62ee60
Update
GregoryComer b2ab3a5
Update
GregoryComer c23c3e9
Update
GregoryComer c99c41a
Update
GregoryComer bf57d6c
Update
GregoryComer f261355
Update
GregoryComer c3a24f9
Update
GregoryComer 1697cbc
Update
GregoryComer b94b45e
Update
GregoryComer 5740f0a
Update
GregoryComer ed6840d
Update
GregoryComer f2a7e1f
Update
GregoryComer 0e162ab
Update
GregoryComer c6bd56b
Update
GregoryComer 144a8ae
Update
GregoryComer 6f85fc1
Update
GregoryComer 2439022
Update
GregoryComer bd79ef2
Update
GregoryComer 8932c29
Update
GregoryComer ea2549c
Update
GregoryComer ffaa1c3
Update
GregoryComer bba2fa9
Update
GregoryComer 3a3e026
Update
GregoryComer 2c4488f
Update
GregoryComer 491ec2b
Update
GregoryComer 375b076
Update
GregoryComer fc1c2a7
Update
GregoryComer 78086b4
Update
GregoryComer 285e058
Update
GregoryComer cfbc408
Update
GregoryComer f4b0dc2
Update
GregoryComer 5e92884
Update
GregoryComer 605a0ad
Update
GregoryComer aa27776
Update
GregoryComer 90ce443
Update
GregoryComer 67f60e4
Update
GregoryComer 1b9315e
Update
GregoryComer 54563ee
Update
GregoryComer 94d89c4
Update
GregoryComer d79d1a8
Update
GregoryComer 1e3e79c
Update
GregoryComer 6043952
Update
GregoryComer 1c136d7
Update
GregoryComer 780519f
Update
GregoryComer 7e1a002
Update
GregoryComer a628d29
Update
GregoryComer 3615d89
Update
GregoryComer e994bc1
Update
GregoryComer 0aba8e1
Update
GregoryComer 4329bf6
Update
GregoryComer 105aabc
Update
GregoryComer c1a51ee
Update
GregoryComer dd30127
Update
GregoryComer 4216805
Update
GregoryComer 092b8d1
Update
GregoryComer 1d34f49
Update
GregoryComer 933fba2
Update
GregoryComer d468ae4
Update
GregoryComer acbd480
Update
GregoryComer e515bf1
Update
GregoryComer 803db00
Update
GregoryComer ab18089
Update
GregoryComer 49944fa
Update
GregoryComer 60f3932
Update
GregoryComer fe201b8
Update
GregoryComer 1897d4e
Update
GregoryComer f65d80f
Update
GregoryComer 0d1f097
Update
GregoryComer f0c2490
Update
GregoryComer 0046b02
Update
GregoryComer 32e1029
Update
GregoryComer f4df9c9
Update
GregoryComer 832cea5
Update
GregoryComer 40819b9
Update
GregoryComer 871312a
Update
GregoryComer 53990fe
Update
GregoryComer 567d055
Update
GregoryComer cd998cf
Update
GregoryComer 2a837ab
Update
GregoryComer 51c392a
Update
GregoryComer f066d46
Update
GregoryComer ab5415f
Update
GregoryComer 31bc137
Update
GregoryComer dae5d43
Update
GregoryComer 06b5532
Update
GregoryComer a343abc
Update
GregoryComer 778f7cd
Update
GregoryComer c19a8ea
Update
GregoryComer b4a8428
Update
GregoryComer 637b8a2
Update
GregoryComer 7141f6c
Update
GregoryComer 4b43363
Update
GregoryComer 88d1dd3
Update
GregoryComer c583fa1
Update
GregoryComer 995c4b5
Update
GregoryComer 0fc4475
Update
GregoryComer 1fec71c
Update
GregoryComer ad8ab13
Update
GregoryComer a3c2dbe
Update
GregoryComer 1008ad4
Update
GregoryComer e94e9ae
Update
GregoryComer 98eee4d
Update
GregoryComer ad04155
Update
GregoryComer a5f702f
Update
GregoryComer 569916c
Update
GregoryComer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do? i.e. Minimal ==> "do the verification but don't print warnings"?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't actually cause any change in verification, because the extended verification feature isn't compiled into pybindings by default. So the runtime logs a warning because it was requested but not available. This change updates the code to not ask for extended verification.
Here's the relevant code from the runtime. The "InternalConsistency verification requested but not available " log is the one contributing to log spam.
executorch/runtime/executor/program.cpp
Lines 123 to 136 in d7ecd87