Skip to content

[Backend Tester] Reduce log verbosity / spam #13312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 181 commits into from
Aug 13, 2025
Merged
Show file tree
Hide file tree
Changes from 170 commits
Commits
Show all changes
181 commits
Select commit Hold shift + click to select a range
f120e70
Update
GregoryComer Jul 18, 2025
0fb85e6
Update
GregoryComer Jul 18, 2025
4d8d844
Update
GregoryComer Jul 19, 2025
dc12b40
Update
GregoryComer Jul 21, 2025
ead0616
Update
GregoryComer Jul 22, 2025
0f13676
Update
GregoryComer Jul 22, 2025
b0b01f2
Update
GregoryComer Jul 22, 2025
8b9c9ef
Update
GregoryComer Jul 22, 2025
06bf03a
Update
GregoryComer Jul 22, 2025
2f8f49b
Update
GregoryComer Jul 22, 2025
8ca7766
Update
GregoryComer Jul 22, 2025
bffb95f
Update
GregoryComer Jul 22, 2025
d21492b
Update
GregoryComer Jul 22, 2025
e2c4ea5
Update
GregoryComer Jul 22, 2025
8230848
Update
GregoryComer Jul 22, 2025
2a1f564
Update
GregoryComer Jul 22, 2025
b35e7b1
Update
GregoryComer Jul 22, 2025
5c4c6ce
Update
GregoryComer Jul 22, 2025
9397803
Update
GregoryComer Jul 22, 2025
9dfeb5a
Update
GregoryComer Jul 22, 2025
ff5c4a5
Update
GregoryComer Jul 22, 2025
42a5de5
Update
GregoryComer Jul 22, 2025
402d8f5
Update
GregoryComer Jul 22, 2025
34d3ab3
Update
GregoryComer Jul 22, 2025
1105e04
Update
GregoryComer Jul 22, 2025
482bd21
Update
GregoryComer Jul 22, 2025
ea548b7
Update
GregoryComer Jul 23, 2025
4108f54
Update
GregoryComer Jul 23, 2025
7ef236b
Update
GregoryComer Jul 23, 2025
4a58c9d
Update
GregoryComer Jul 23, 2025
3b866b4
Update
GregoryComer Jul 23, 2025
5ba25cb
Update
GregoryComer Jul 23, 2025
19760fc
Update
GregoryComer Jul 23, 2025
81dfb07
Update
GregoryComer Jul 23, 2025
4d50265
Update
GregoryComer Jul 23, 2025
5f66043
Update
GregoryComer Jul 23, 2025
24e919d
Update
GregoryComer Jul 23, 2025
523cc20
Update
GregoryComer Jul 23, 2025
74c95fe
Update
GregoryComer Jul 23, 2025
5d437b1
Update
GregoryComer Jul 23, 2025
89757ce
Update
GregoryComer Jul 23, 2025
423f79a
Update
GregoryComer Jul 23, 2025
69f7f9c
Update
GregoryComer Jul 23, 2025
c0f6224
Update
GregoryComer Jul 23, 2025
e2ea2a3
Update
GregoryComer Jul 23, 2025
7a2fab5
Update
GregoryComer Jul 23, 2025
033c231
Update
GregoryComer Jul 23, 2025
a9ed762
Update
GregoryComer Jul 23, 2025
64b174a
Update
GregoryComer Jul 23, 2025
3976629
Update
GregoryComer Jul 23, 2025
27cd171
Update
GregoryComer Jul 23, 2025
7bdd3e5
Update
GregoryComer Jul 23, 2025
b1254cd
Update
GregoryComer Jul 23, 2025
f2e2289
Update
GregoryComer Jul 23, 2025
cdd15c1
Update
GregoryComer Jul 23, 2025
e2df06e
Update
GregoryComer Jul 23, 2025
4461bd8
Update
GregoryComer Jul 23, 2025
7e97fd0
Update
GregoryComer Jul 23, 2025
bcb697c
Update
GregoryComer Jul 23, 2025
11a5a02
Update
GregoryComer Jul 24, 2025
244b146
Update
GregoryComer Jul 24, 2025
de21ac2
Update
GregoryComer Jul 24, 2025
fd26fc7
Update
GregoryComer Jul 24, 2025
4ae840d
Update
GregoryComer Jul 24, 2025
710ea49
Update
GregoryComer Jul 24, 2025
32f54b0
Update
GregoryComer Jul 24, 2025
a27d18c
Update
GregoryComer Jul 24, 2025
2eb59fc
Update
GregoryComer Jul 24, 2025
5cc4941
Update
GregoryComer Jul 24, 2025
ef7af5c
Update
GregoryComer Jul 24, 2025
18e89c1
Update
GregoryComer Jul 24, 2025
4719c90
Update
GregoryComer Jul 25, 2025
dd09555
Update
GregoryComer Aug 8, 2025
f1db3a0
Update
GregoryComer Aug 8, 2025
e0700b2
Update
GregoryComer Aug 8, 2025
f260b50
Update
GregoryComer Aug 8, 2025
d62ee60
Update
GregoryComer Aug 8, 2025
b2ab3a5
Update
GregoryComer Aug 8, 2025
c23c3e9
Update
GregoryComer Aug 8, 2025
c99c41a
Update
GregoryComer Aug 9, 2025
bf57d6c
Update
GregoryComer Aug 9, 2025
f261355
Update
GregoryComer Aug 11, 2025
c3a24f9
Update
GregoryComer Aug 11, 2025
1697cbc
Update
GregoryComer Aug 11, 2025
b94b45e
Update
GregoryComer Aug 11, 2025
5740f0a
Update
GregoryComer Aug 11, 2025
ed6840d
Update
GregoryComer Aug 11, 2025
f2a7e1f
Update
GregoryComer Aug 11, 2025
0e162ab
Update
GregoryComer Aug 11, 2025
c6bd56b
Update
GregoryComer Aug 11, 2025
144a8ae
Update
GregoryComer Aug 12, 2025
6f85fc1
Update
GregoryComer Aug 12, 2025
2439022
Update
GregoryComer Aug 12, 2025
bd79ef2
Update
GregoryComer Aug 12, 2025
8932c29
Update
GregoryComer Aug 12, 2025
ea2549c
Update
GregoryComer Aug 12, 2025
ffaa1c3
Update
GregoryComer Aug 12, 2025
bba2fa9
Update
GregoryComer Aug 12, 2025
3a3e026
Update
GregoryComer Aug 12, 2025
2c4488f
Update
GregoryComer Aug 12, 2025
491ec2b
Update
GregoryComer Aug 12, 2025
375b076
Update
GregoryComer Aug 12, 2025
fc1c2a7
Update
GregoryComer Aug 12, 2025
78086b4
Update
GregoryComer Aug 12, 2025
285e058
Update
GregoryComer Aug 12, 2025
cfbc408
Update
GregoryComer Aug 12, 2025
f4b0dc2
Update
GregoryComer Aug 12, 2025
5e92884
Update
GregoryComer Aug 12, 2025
605a0ad
Update
GregoryComer Aug 12, 2025
aa27776
Update
GregoryComer Aug 12, 2025
90ce443
Update
GregoryComer Aug 12, 2025
67f60e4
Update
GregoryComer Aug 12, 2025
1b9315e
Update
GregoryComer Aug 12, 2025
54563ee
Update
GregoryComer Aug 12, 2025
94d89c4
Update
GregoryComer Aug 12, 2025
d79d1a8
Update
GregoryComer Aug 12, 2025
1e3e79c
Update
GregoryComer Aug 12, 2025
6043952
Update
GregoryComer Aug 12, 2025
1c136d7
Update
GregoryComer Aug 12, 2025
780519f
Update
GregoryComer Aug 12, 2025
7e1a002
Update
GregoryComer Aug 12, 2025
a628d29
Update
GregoryComer Aug 12, 2025
3615d89
Update
GregoryComer Aug 12, 2025
e994bc1
Update
GregoryComer Aug 12, 2025
0aba8e1
Update
GregoryComer Aug 12, 2025
4329bf6
Update
GregoryComer Aug 12, 2025
105aabc
Update
GregoryComer Aug 12, 2025
c1a51ee
Update
GregoryComer Aug 12, 2025
dd30127
Update
GregoryComer Aug 12, 2025
4216805
Update
GregoryComer Aug 12, 2025
092b8d1
Update
GregoryComer Aug 12, 2025
1d34f49
Update
GregoryComer Aug 12, 2025
933fba2
Update
GregoryComer Aug 12, 2025
d468ae4
Update
GregoryComer Aug 12, 2025
acbd480
Update
GregoryComer Aug 12, 2025
e515bf1
Update
GregoryComer Aug 12, 2025
803db00
Update
GregoryComer Aug 12, 2025
ab18089
Update
GregoryComer Aug 12, 2025
49944fa
Update
GregoryComer Aug 12, 2025
60f3932
Update
GregoryComer Aug 12, 2025
fe201b8
Update
GregoryComer Aug 12, 2025
1897d4e
Update
GregoryComer Aug 12, 2025
f65d80f
Update
GregoryComer Aug 12, 2025
0d1f097
Update
GregoryComer Aug 12, 2025
f0c2490
Update
GregoryComer Aug 12, 2025
0046b02
Update
GregoryComer Aug 12, 2025
32e1029
Update
GregoryComer Aug 12, 2025
f4df9c9
Update
GregoryComer Aug 12, 2025
832cea5
Update
GregoryComer Aug 12, 2025
40819b9
Update
GregoryComer Aug 12, 2025
871312a
Update
GregoryComer Aug 12, 2025
53990fe
Update
GregoryComer Aug 12, 2025
567d055
Update
GregoryComer Aug 12, 2025
cd998cf
Update
GregoryComer Aug 12, 2025
2a837ab
Update
GregoryComer Aug 12, 2025
51c392a
Update
GregoryComer Aug 12, 2025
f066d46
Update
GregoryComer Aug 12, 2025
ab5415f
Update
GregoryComer Aug 12, 2025
31bc137
Update
GregoryComer Aug 12, 2025
dae5d43
Update
GregoryComer Aug 12, 2025
06b5532
Update
GregoryComer Aug 12, 2025
a343abc
Update
GregoryComer Aug 12, 2025
778f7cd
Update
GregoryComer Aug 12, 2025
c19a8ea
Update
GregoryComer Aug 12, 2025
b4a8428
Update
GregoryComer Aug 12, 2025
637b8a2
Update
GregoryComer Aug 12, 2025
7141f6c
Update
GregoryComer Aug 12, 2025
4b43363
Update
GregoryComer Aug 12, 2025
88d1dd3
Update
GregoryComer Aug 12, 2025
c583fa1
Update
GregoryComer Aug 12, 2025
995c4b5
Update
GregoryComer Aug 13, 2025
0fc4475
Update
GregoryComer Aug 13, 2025
1fec71c
Update
GregoryComer Aug 13, 2025
ad8ab13
Update
GregoryComer Aug 13, 2025
a3c2dbe
Update
GregoryComer Aug 13, 2025
1008ad4
Update
GregoryComer Aug 13, 2025
e94e9ae
Update
GregoryComer Aug 13, 2025
98eee4d
Update
GregoryComer Aug 13, 2025
ad04155
Update
GregoryComer Aug 13, 2025
a5f702f
Update
GregoryComer Aug 13, 2025
569916c
Update
GregoryComer Aug 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backends/test/harness/stages/serialize.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
try:
from executorch.extension.pybindings.portable_lib import ( # @manual
_load_for_executorch_from_buffer,
Verification,
)
except ImportError as e:
logger.warning(f"{e=}")
Expand All @@ -39,7 +40,9 @@ def graph_module(self) -> None:

def run_artifact(self, inputs):
inputs_flattened, _ = tree_flatten(inputs)
executorch_module = _load_for_executorch_from_buffer(self.buffer)
executorch_module = _load_for_executorch_from_buffer(
self.buffer, program_verification=Verification.Minimal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do? i.e. Minimal ==> "do the verification but don't print warnings"?

Copy link
Member Author

@GregoryComer GregoryComer Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually cause any change in verification, because the extended verification feature isn't compiled into pybindings by default. So the runtime logs a warning because it was requested but not available. This change updates the code to not ask for extended verification.

Here's the relevant code from the runtime. The "InternalConsistency verification requested but not available " log is the one contributing to log spam.

#if ET_ENABLE_PROGRAM_VERIFICATION
EXECUTORCH_SCOPE_PROF("Program::verify_internal_consistency");
flatbuffers::Verifier verifier(
reinterpret_cast<const uint8_t*>(program_data->data()),
program_data->size());
bool ok = executorch_flatbuffer::VerifyProgramBuffer(verifier);
ET_CHECK_OR_RETURN_ERROR(
ok,
InvalidProgram,
"Verification failed; data may be truncated or corrupt");
#else
ET_LOG(
Info, "InternalConsistency verification requested but not available");
#endif

)
executorch_output = copy.deepcopy(
executorch_module.run_method("forward", tuple(inputs_flattened))
)
Expand Down
4 changes: 3 additions & 1 deletion backends/test/harness/stages/to_edge_transform_and_lower.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ def __init__(
if default_partitioner_cls is not None
else []
)
self.edge_compile_conf = edge_compile_config or EdgeCompileConfig()
self.edge_compile_conf = edge_compile_config or EdgeCompileConfig(
_check_ir_validity=False
)
self.edge_dialect_program = None

def stage_type(self) -> StageType:
Expand Down
3 changes: 3 additions & 0 deletions backends/test/suite/context.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
# Test run context management. This is used to determine the test context for reporting
# purposes.
class TestContext:
subtest_index: int

def __init__(
self, test_name: str, test_base_name: str, flow_name: str, params: dict | None
):
self.test_name = test_name
self.test_base_name = test_base_name
self.flow_name = flow_name
self.params = params
self.subtest_index = 0

def __enter__(self):
global _active_test_context
Expand Down
1 change: 1 addition & 0 deletions backends/test/suite/models/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ def run_model_test(
flow,
context.test_name,
context.test_base_name,
0, # subtest_index - currently unused for model tests
context.params,
dynamic_shapes=dynamic_shapes,
)
Expand Down
4 changes: 4 additions & 0 deletions backends/test/suite/operators/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,16 @@ def _test_op(
flow,
context.test_name,
context.test_base_name,
context.subtest_index,
context.params,
generate_random_test_inputs=generate_random_test_inputs,
)

log_test_summary(run_summary)

# This is reset when a new test is started - it creates the context per-test.
context.subtest_index = context.subtest_index + 1

if not run_summary.result.is_success():
if run_summary.result.is_backend_failure():
raise RuntimeError("Test failure.") from run_summary.error
Expand Down
12 changes: 6 additions & 6 deletions backends/test/suite/operators/test_amax.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,39 +207,39 @@ def test_amax_edge_cases(self, flow: TestFlow) -> None:
AmaxModel(),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
AmaxModel(dim=0),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
AmaxModel(dim=1),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)

x = torch.tensor([[1.0, float("nan"), 3.0], [4.0, 5.0, float("nan")]])
self._test_op(
AmaxModel(),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
AmaxModel(dim=0),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
AmaxModel(dim=1),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)

def test_amax_scalar(self, flow: TestFlow) -> None:
Expand Down
12 changes: 6 additions & 6 deletions backends/test/suite/operators/test_amin.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,39 +209,39 @@ def test_amin_edge_cases(self, flow: TestFlow) -> None:
AminModel(),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
AminModel(dim=0),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
AminModel(dim=1),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)

x = torch.tensor([[1.0, float("nan"), 3.0], [4.0, 5.0, float("nan")]])
self._test_op(
AminModel(),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
AminModel(dim=0),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
AminModel(dim=1),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)

def test_amin_scalar(self, flow: TestFlow) -> None:
Expand Down
12 changes: 6 additions & 6 deletions backends/test/suite/operators/test_argmax.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,39 +149,39 @@ def test_argmax_edge_cases(self, flow: TestFlow) -> None:
ArgmaxModel(),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
ArgmaxModel(dim=0),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
ArgmaxModel(dim=1),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)

x = torch.tensor([[1.0, float("nan"), 3.0], [4.0, 5.0, float("nan")]])
self._test_op(
ArgmaxModel(),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
ArgmaxModel(dim=0),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
ArgmaxModel(dim=1),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)

x = torch.tensor([5.0])
Expand Down
12 changes: 6 additions & 6 deletions backends/test/suite/operators/test_argmin.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,39 +149,39 @@ def test_argmin_edge_cases(self, flow: TestFlow) -> None:
ArgminModel(),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
ArgminModel(dim=0),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
ArgminModel(dim=1),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)

x = torch.tensor([[1.0, float("nan"), 3.0], [4.0, 5.0, float("nan")]])
self._test_op(
ArgminModel(),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
ArgminModel(dim=0),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)
self._test_op(
ArgminModel(dim=1),
(x,),
flow,
use_random_test_inputs=False,
generate_random_test_inputs=False,
)

x = torch.tensor([5.0])
Expand Down
4 changes: 2 additions & 2 deletions backends/test/suite/operators/test_floor.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@


class FloorModel(torch.nn.Module):
def __init__(self):
super().__init__()
def forward(self, x):
return torch.floor(x)


@operator_test
Expand Down
Loading
Loading