Skip to content

Arm backend: Remove function getNodeArgs #13316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zingo merged 1 commit into from
Aug 12, 2025
Merged

Arm backend: Remove function getNodeArgs #13316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions backends/arm/process_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from executorch.backends.arm.operators.node_visitor import NodeVisitor
from executorch.backends.arm.tosa_mapping import TosaArg
from executorch.backends.arm.tosa_specification import TosaSpecification
from executorch.backends.arm.tosa_utils import getNodeArgs, tosa_shape
from executorch.backends.arm.tosa_utils import tosa_shape
from torch._export.utils import (
get_buffer,
get_lifted_tensor_constant,
Expand All @@ -33,7 +33,10 @@ def process_call_function(
tosa_spec: TosaSpecification,
):
# Unpack arguments and convert
inputs = getNodeArgs(node, tosa_spec)
try:
inputs = [TosaArg(arg, tosa_spec) for arg in node.args]
except ValueError as e:
raise ValueError(f"Failed processing args to op:\n{node}") from e

# Convert output (this node itself)
try:
Expand Down
9 changes: 1 addition & 8 deletions backends/arm/tosa_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import torch

from executorch.backends.arm.tosa_mapping import extract_tensor_meta, TosaArg
from executorch.backends.arm.tosa_mapping import extract_tensor_meta

from executorch.backends.arm.tosa_specification import TosaSpecification
from executorch.exir.dialects._ops import ops as exir_ops
Expand All @@ -26,13 +26,6 @@
logger = logging.getLogger(__name__)


def getNodeArgs(node: Node, tosa_spec: TosaSpecification) -> list[TosaArg]:
try:
return [TosaArg(arg, tosa_spec) for arg in node.args]
except ValueError as e:
raise ValueError(f"Failed processing args to op:\n{node}") from e


def are_fake_tensors_broadcastable(
fake_tensors: list[FakeTensor],
) -> tuple[bool, list[int]]:
Expand Down
Loading