-
Notifications
You must be signed in to change notification settings - Fork 752
Arm backend: Bump Arm baremetal compilers to gcc 14.3 #13317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm backend: Bump Arm baremetal compilers to gcc 14.3 #13317
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13317
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 5 Unrelated FailuresAs of commit b63af4c with merge base dfc387b ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| toolchain_dir="arm-gnu-toolchain-13.3.rel1-x86_64-arm-none-eabi" | ||
| toolchain_md5_checksum="0601a9588bc5b9c99ad2b56133b7f118" | ||
| fi | ||
| toolchain_url="https://developer.arm.com/-/media/Files/downloads/gnu/14.3.rel1/binrel/arm-gnu-toolchain-14.3.rel1-x86_64-arm-none-eabi.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: if the URL names are predictable, extract 14.3 out as a variable might be better to avoid missing some toolchain in future updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of agree and maybe we want to do this over time. As it's part of the filename it is now at lease nice to directly be able to cut&paste and search the web for it. Lets see if we change later.
Signed-off-by: Zingo Andersen <[email protected]> Change-Id: Id28c58c63d31e747e53120e14b1a5bac4e53574d
7b4c6f2 to
959a6d4
Compare
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Will be replace with a better/newer version some day hopefully. This had gone old and needs a rebase. |
cc @digantdesai @freddan80 @per @oscarandersson8218