Skip to content

Conversation

@zingo
Copy link
Collaborator

@zingo zingo commented Aug 12, 2025

Generate both sh and fish shell versions of the setup_path script

cc @digantdesai @freddan80 @per @oscarandersson8218

@zingo zingo requested a review from digantdesai as a code owner August 12, 2025 13:16
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Aug 12, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13323

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 3 Pending, 1 Unrelated Failure

As of commit c819b2a with merge base 1164fe4 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2025
@zingo
Copy link
Collaborator Author

zingo commented Aug 13, 2025

This should go in after #13369

@zingo zingo marked this pull request as draft August 13, 2025 16:43
…th script

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: I3d982c39a22821287dffd9336619c4b093574d71
@zingo zingo force-pushed the Arm-backend-Generate-both-sh-and-fish-shell-versions-of-the-setup_path-script branch from a6b865b to c819b2a Compare August 19, 2025 14:31
@zingo
Copy link
Collaborator Author

zingo commented Aug 20, 2025

fails are unrelated

@zingo zingo marked this pull request as ready for review August 20, 2025 09:13
@zingo zingo merged commit bd92f1a into pytorch:main Aug 20, 2025
364 of 383 checks passed
@zingo zingo deleted the Arm-backend-Generate-both-sh-and-fish-shell-versions-of-the-setup_path-script branch August 20, 2025 11:01
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
…orch#13323)

Generate both sh and fish shell versions of the setup_path script

Signed-off-by: Zingo Andersen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants