Skip to content

Conversation

winskuo-quic
Copy link
Collaborator

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

Copy link

pytorch-bot bot commented Aug 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13352

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 7 New Failures, 8 Unrelated Failures

As of commit ebb55e1 with merge base 1520f9f (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/qnn_2_37 branch 2 times, most recently from 863fd9a to b6bc5a1 Compare August 13, 2025 10:08
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results August 13, 2025 10:24 — with GitHub Actions Failure
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results August 13, 2025 12:34 — with GitHub Actions Failure
@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/qnn_2_37 branch from 41638dd to e8b377d Compare August 13, 2025 13:56
@winskuo-quic winskuo-quic changed the title [DO NOT MERGE] Test QNN2.37 uplevel Test QNN2.37 uplevel Aug 13, 2025
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results August 13, 2025 14:17 — with GitHub Actions Failure
@winskuo-quic winskuo-quic mentioned this pull request Aug 13, 2025
@winskuo-quic winskuo-quic changed the title Test QNN2.37 uplevel Qualcomm AI Engine Direct - Test QNN2.37 uplevel Aug 15, 2025
@cccclai
Copy link
Contributor

cccclai commented Aug 28, 2025

@winskuo-quic do you know when it will be ready to bump the version?

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/qnn_2_37 branch from e8b377d to 5f9ed48 Compare August 28, 2025 05:15
@winskuo-quic
Copy link
Collaborator Author

@winskuo-quic do you know when it will be ready to bump the version?

Hi @cccclai,
I think this PR is ready and we can do uplevel first. Please have a look.
There are only a few UT failing under specific use cases in 2.37.0, which should not affect current GA enablement.
We can do up level first, and we will have another PR addressing these issues.

@winskuo-quic winskuo-quic marked this pull request as ready for review August 28, 2025 05:18
@winskuo-quic winskuo-quic requested a review from cccclai as a code owner August 28, 2025 05:18
@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results August 28, 2025 05:30 — with GitHub Actions Failure
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D81207378.

@cccclai
Copy link
Contributor

cccclai commented Aug 28, 2025

There is a bit more hardcode logic introduced here #13687 mind updating together?

@winskuo-quic
Copy link
Collaborator Author

There is a bit more hardcode logic introduced here #13687 mind updating together?

Thanks for reviewing the PR.
I have pushed a new commit that should change 2.28.0 to 2.37.0.

@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results August 28, 2025 07:27 — with GitHub Actions Failure
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D81207378.

@cccclai
Copy link
Contributor

cccclai commented Aug 28, 2025

Thanks! Can you rebase?

@winskuo-quic winskuo-quic force-pushed the dev1/winskuo/qnn_2_37 branch from b5d9007 to eea5120 Compare August 29, 2025 00:18
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D81207378.

@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results August 29, 2025 00:43 — with GitHub Actions Failure
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D81207378.

2 similar comments
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D81207378.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D81207378.

@cccclai
Copy link
Contributor

cccclai commented Aug 31, 2025

Sorry still having trouble to import, can you rebase again?

@winskuo-quic winskuo-quic had a problem deploying to upload-benchmark-results September 1, 2025 02:06 — with GitHub Actions Failure
@winskuo-quic
Copy link
Collaborator Author

A lot of CIs are failing, which did not happen in other PRs I pushed.
I am unsure if it is this PR that is causing these to fail. A lot of them seems related to AWS server error or $SECRET_EXECUTORCH_HF_TOKEN not found.

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D81207378.

@cccclai
Copy link
Contributor

cccclai commented Sep 1, 2025

A lot of CIs are failing, which did not happen in other PRs I pushed. I am unsure if it is this PR that is causing these to fail. A lot of them seems related to AWS server error or $SECRET_EXECUTORCH_HF_TOKEN not found.

I think it just trigger the trunk job. Aside from, the import works and I'll wait for the CI signal. If it's all good, we will merge this PR

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cccclai cccclai merged commit c3f8d64 into pytorch:main Sep 2, 2025
223 of 238 checks passed
@cccclai
Copy link
Contributor

cccclai commented Sep 3, 2025

@winskuo-quic there are a few more androd perf test failing seems related to this PR, can you take a look?
https://hud.pytorch.org/pytorch/executorch/commit/c3f8d64d9d24ad8a69537408ef2f05e3ba4670ac

winskuo-quic added a commit to CodeLinaro/executorch that referenced this pull request Sep 4, 2025
winskuo-quic added a commit to CodeLinaro/executorch that referenced this pull request Sep 4, 2025
@shoumikhin
Copy link
Contributor

@winskuo-quic please check is this change has lead to the nightly CI failures, like this one
https://hud.pytorch.org/pytorch/executorch/commit/43bd889fc22199df12a301c6cfa7b2142e6930e7

2025-09-04T02:45:03.2835693Z In file included from /pytorch/executorch/backends/qualcomm/runtime/backends/QnnImplementation.cpp:8:
2025-09-04T02:45:03.2837864Z In file included from /pytorch/executorch/backends/qualcomm/runtime/backends/QnnImplementation.h:11:
2025-09-04T02:45:03.2840433Z /pytorch/executorch/backends/qualcomm/runtime/backends/QnnFunctionInterface.h:10:10: fatal error: 'QnnInterface.h' file not found
2025-09-04T02:45:03.2842379Z   #include "QnnInterface.h"
2025-09-04T02:45:03.2842983Z            ^~~~~~~~~~~~~~~~
2025-09-04T02:45:03.2843544Z   1 error generated.

2025-09-04T02:45:03.2863171Z In file included from /pytorch/executorch/backends/qualcomm/runtime/backends/QnnSysImplementation.cpp:10:
2025-09-04T02:45:03.2865475Z In file included from /pytorch/executorch/backends/qualcomm/runtime/backends/QnnSysImplementation.h:11:
2025-09-04T02:45:03.2868370Z /pytorch/executorch/backends/qualcomm/runtime/backends/QnnSysFunctionInterface.h:10:10: fatal error: 'System/QnnSystemInterface.h' file not found
2025-09-04T02:45:03.2871804Z   #include "System/QnnSystemInterface.h"
2025-09-04T02:45:03.2872568Z            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2025-09-04T02:45:03.2873241Z   1 error generated.
Screenshot 2025-09-04 at 13 53 19

@winskuo-quic
Copy link
Collaborator Author

@winskuo-quic please check is this change has lead to the nightly CI failures, like this one https://hud.pytorch.org/pytorch/executorch/commit/43bd889fc22199df12a301c6cfa7b2142e6930e7

2025-09-04T02:45:03.2835693Z In file included from /pytorch/executorch/backends/qualcomm/runtime/backends/QnnImplementation.cpp:8:
2025-09-04T02:45:03.2837864Z In file included from /pytorch/executorch/backends/qualcomm/runtime/backends/QnnImplementation.h:11:
2025-09-04T02:45:03.2840433Z /pytorch/executorch/backends/qualcomm/runtime/backends/QnnFunctionInterface.h:10:10: fatal error: 'QnnInterface.h' file not found
2025-09-04T02:45:03.2842379Z   #include "QnnInterface.h"
2025-09-04T02:45:03.2842983Z            ^~~~~~~~~~~~~~~~
2025-09-04T02:45:03.2843544Z   1 error generated.

2025-09-04T02:45:03.2863171Z In file included from /pytorch/executorch/backends/qualcomm/runtime/backends/QnnSysImplementation.cpp:10:
2025-09-04T02:45:03.2865475Z In file included from /pytorch/executorch/backends/qualcomm/runtime/backends/QnnSysImplementation.h:11:
2025-09-04T02:45:03.2868370Z /pytorch/executorch/backends/qualcomm/runtime/backends/QnnSysFunctionInterface.h:10:10: fatal error: 'System/QnnSystemInterface.h' file not found
2025-09-04T02:45:03.2871804Z   #include "System/QnnSystemInterface.h"
2025-09-04T02:45:03.2872568Z            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2025-09-04T02:45:03.2873241Z   1 error generated.
Screenshot 2025-09-04 at 13 53 19

Hi @shoumikhin,
I think there's a conflict when merging this PR, where another PR is also modifying the QNN_SDK_ROOT.
I believe this PR should be able to fix it: #13927.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants