switch top-level ExecuTorch build from executorch_srcs.cmake to build_variables.bzl #13358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2025
|
noting CI is good |
GregoryComer
approved these changes
Aug 15, 2025
swolchok
requested review from
JacobSzwejbka,
cccclai,
digantdesai,
jackzhxng,
kimishpatel,
lucylq,
manuelcandales,
mcr229 and
mergennachin
as code owners
[ghstack-poisoned]
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…_variables.bzl (pytorch#13358) Will remove other uses of EXECUTORCH_SRCS_FILE in follow-up PR; want to demonstrate the build working first. pytorch#8268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will remove other uses of EXECUTORCH_SRCS_FILE in follow-up PR; want to demonstrate the build working first. #8268
Differential Revision: D80187443