Skip to content

Conversation

@GregoryComer
Copy link
Member

Summary

My recent tester changes added a generate_etrecord parameter to the tester to_edge_transform_and_lower API. This broke some of the ARM tests. I missed this due to pre-existing ARM CI failures (I didn't look closely enough at failure log). This change adds the parameter to the ARM tester to fix the signature. It should be a no-op for the ARM tests themselves.

Test plan

CI

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13362

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 5 Unrelated Failures

As of commit a8095c1 with merge base 310a05d (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2025
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Aug 13, 2025
@GregoryComer GregoryComer changed the title Fix Arm tester after tester etrecord change Fix Arm tester after etrecord signature change Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant