Arm backend: Add missing using-declaration in VGFBackend.cpp #13460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR pytorch#13004 moved `EValue` to the `Span` namespace but did not add the corresponding using-declaration in VGFBackend.cpp. Adds the missing using-declaration to fix the build. Change-Id: I58f1acff3fec41aee433283495ff4bbf6cb34512 Signed-off-by: Yufeng Shi <[email protected]>
YufengShi-dudu
requested review from
AdrianLundell,
ArmRyan,
Sebastian-Larsson and
zingo
YufengShi-dudu
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13460
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit f1bc7ab with merge base 1b4968f ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
ArmRyan
approved these changes
Aug 15, 2025
Collaborator
ArmRyan
left a comment
ArmRyan
left a comment
There was a problem hiding this comment.
Approved in internal review
zingo
approved these changes
Aug 15, 2025
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…#13460) The PR pytorch#13004 moved `EValue` to the `Span` namespace but did not add the corresponding using-declaration in VGFBackend.cpp. Adds the missing using-declaration to fix the build. Signed-off-by: Yufeng Shi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #13004 moved
EValueto theSpannamespace but did not add the corresponding using-declaration in VGFBackend.cpp.Adds the missing using-declaration to fix the build.
Change-Id: I58f1acff3fec41aee433283495ff4bbf6cb34512
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218