Skip to content

[Backend Tester] Add test flows for QNN #13469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 33 commits into
base: gh/GregoryComer/131/head
Choose a base branch
from

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 18, 2025

Add test flows for each of the supported QNN quantization modes. I followed the guidance in the docs and example code for the overall lowering flow. Add jobs to nightly CI.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Aug 18, 2025

Copy link

pytorch-bot bot commented Aug 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13469

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit e345809 with merge base 0856f59 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 18, 2025
ghstack-source-id: 27fe0f8
ghstack-comment-id: 3195495418
Pull-Request: #13469
[ghstack-poisoned]
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 18, 2025
ghstack-source-id: ff64e3f
ghstack-comment-id: 3195495418
Pull-Request: #13469
[ghstack-poisoned]
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 18, 2025
ghstack-source-id: 78d3f9e
ghstack-comment-id: 3195495418
Pull-Request: #13469
[ghstack-poisoned]
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 18, 2025
ghstack-source-id: 1b2b30f
ghstack-comment-id: 3195495418
Pull-Request: #13469
[ghstack-poisoned]
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 19, 2025
ghstack-source-id: ade8442
ghstack-comment-id: 3195495418
Pull-Request: #13469
@@ -42,7 +42,7 @@ jobs:
strategy:
fail-fast: false
matrix:
flow: [qualcomm, vulkan, xnnpack, xnnpack_static_int8_per_channel]
flow: [qualcomm, qualcomm_16a16w, qualcomm_16a8w, qualcomm_16a4w, qualcomm_16a4w_block, qualcomm_8a8w, vulkan, xnnpack, xnnpack_static_int8_per_channel]
Copy link
Contributor

@digantdesai digantdesai Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not also add more for xnnpack? Just curious

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename to qnn_* to align with the naming convention

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll update it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not also add more for xnnpack? Just curious

Added a few more PT2E flows in the stack. I'll add int4 as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename to qnn_* to align with the naming convention

Done.

[ghstack-poisoned]
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 19, 2025
ghstack-source-id: 924a33d
ghstack-comment-id: 3195495418
Pull-Request: #13469
[ghstack-poisoned]
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Aug 19, 2025
ghstack-source-id: d9a896c
ghstack-comment-id: 3195495418
Pull-Request: #13469
Base automatically changed from gh/GregoryComer/132/head to gh/GregoryComer/131/head August 19, 2025 23:09
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer GregoryComer changed the title [Backend Tester] Add test flows for QNN quantization [Backend Tester] Add test flows for QNN Aug 20, 2025
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants